De-duplicate attributes

[patoarvizu]

(First of all, thanks for the project, I had been looking for something like this for a while and I gave InfluxDB-Logger a shot but it wasn't quite what I needed,)

I can't tell if this is an issue with all Hubitats or maybe just the firmware version mine is on, but it seems like in some cases the attributes for a given device are duplicated, e.g.

...
  "attributes": [
    {
      "name": "switch",
      "currentValue": "on",
      "dataType": "ENUM",
      "values": [
        "on",
        "off"
      ]
    },
    {
      "name": "hue",
      "currentValue": 50,
      "dataType": "NUMBER"
    },
    {
      "name": "colorName",
      "currentValue": "Cyan",
      "dataType": "STRING"
    },
    {
      "name": "switch",
      "currentValue": "on",
      "dataType": "ENUM",
      "values": [
        "on",
        "off"
      ]
    }
...

Notice that switch is duplicated, which results in something like:

switch{device_name="living_room"} 1
switch{device_name="living_room"} 1

Could hubitat2prom defensively de-duplicate the list of attributes? To be clear, this doesn't seem to be an issue with hubitat2prom but rather with the responses returned by the Hubitat API, but ideally the data can be cleaned up before being rendered for /metrics, so this is more a feature request than a bug report.

[proffalken]

Thanks, this is definitely something I could look in to, at the moment the logic at https://github.com/BudgetSmartHome/hubitat2prom/blob/main/app.py#L30 means that if an attribute is found more than once for the same device, the last value of that attribute will be the one that is written to the prometheus endpoint.

This is more by accident than design however, so putting something a bit more concrete around this could be a good idea!