Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do brick:Heating_Valve and brick:Cooling_Valve not extend brick:Valve? #678

Open
bresaur opened this issue Dec 2, 2024 · 0 comments

Comments

@bresaur
Copy link

bresaur commented Dec 2, 2024

brick:Heating_Valve and brick:Cooling_Valve extend brick:HVACEquipment, not brick:Valve.

There may be a reason for this, but I did not get it from reading the documentation.
After all, there is HVAC_Valve which extends both brick:HVACEquipment and brick:Valve, so why is brick:Heating_Valve not a subClassOf HVAC:Valve?

Looking at changes in generate_brick.py, it looks like this can be traced back to from #333:
previously, define_classes was called for valve_subclasses with parent=BRICK.Valve
afterwards, define_classes(hvac_valve_subclasses, BRICK.HVAC_Equipment) and
define_classes(valve_subclasses, BRICK.Equipment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant