Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix endpoint payloads inconsistency with particle api #257

Open
AntonPuko opened this issue Sep 29, 2017 · 2 comments
Open

fix endpoint payloads inconsistency with particle api #257

AntonPuko opened this issue Sep 29, 2017 · 2 comments

Comments

@AntonPuko
Copy link

No description provided.

@jlkalberer
Copy link

Can you add more description? What is inconsistent?

@AntonPuko
Copy link
Author

AntonPuko commented Sep 29, 2017

From what I remember:
1 error payloads format:
our:

{
    "error": "Could not get device for ID",
    "ok": false
}

they :
in some cases:

{
    "error": "Permission Denied",
    "info": "I didn't recognize that device name or ID, try opening https://api.particle.io/v1/devices?access_token=3c9f4349104ae651e75aa7b5312f0575fc52bd87"
}

in another:

{
    "ok": false,
    "errors": [
        {
            "code": 401
        }
    ]
}

in another :

{
    "ok": false,
    "error": "Webhook not found"
}

(lol, for these examples I clicked some of their endpoints and they have different error formats everywhere...pffff)
2 device status: we have connected they have online and we don't have status field in products devices at all

So, I didn't check all endpoints, but I think we have such differences in the most payloads(somewhere missed field, somewhere different prop name, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants