Hit information showing incorrectly in addon for TBC Arcane Mage

[Chargerpally]

Bug description

When I first installed this addon, I was a Frost Mage. I respecced to Arcane. Ever since then, it shows my hit information incorrectly. I know that my hit cap number is 76, but it tells me that I'm at a nearly 8% miss rate on level 73 or bosses, as if the addon still believes I'm specced Frost. My spec is majority in to Arcane with the rest in Frost. Should the addon know that I've respecced to Arcane and the hit chance numbers are different? Is there a way to reset the addon to make it aware of my new spec?

I received a response on Curseforge, asking me to create an issue here, saying that it might be an issue with Arcane within ECS.

Screenshots

Version

This is ECS version 2.10.0 in TBC Classic.

[BreakBB]

Hey @Chargerpally thanks for creating this issue.

I had a quick look and this is another good example that I should update ECS to show Spell Hit by magic school. The problem is, that ECS currently fully ignores the "Arcane Focus" talent which gives 10% hit on Arcane spells. On the other hand the "Elemental Precision" talent is also taken into account when specced arcane.

Hopefully I will have some time soon to update and fix this.

[fluegu]

I got some off time coming up and actually am affected by this bug aswell. If you haven't done this until in 2-3 weeks I might open a PR. Time to learn some lua :D

[Chargerpally]

I appreciate any assistance you guys are willing to provide.

I kinda get why it's set up this way though. As long as you know the Arcane hit cap and you only go that high, then any Frostbolts that you cast will still be well below hit cap on +3 lvl and bosses. If you're specced Frost and you meet that hit cap, you're hit capped enough for all specs.

[BreakBB]

Hey @fluegu go ahead and start digging into it. The restructuring for this issue to be solved is kind of a big change though, so I am not sure if it is the best to start with. But I appreciate any help I get to keep ECS in good shape and I will keep trying to use as much time as possible.