Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimate Saving Session reward points #616

Open
2 tasks done
JRascagneres opened this issue Dec 8, 2023 · 1 comment
Open
2 tasks done

Estimate Saving Session reward points #616

JRascagneres opened this issue Dec 8, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request More demand needed A feature that will be considered if there is more demand

Comments

@JRascagneres
Copy link

Describe the feature

It would be nice if following a saving session there was an estimated reward field that could be populated per session. There are a couple of websites such as - https://savingsessions.streamlit.app/ (https://github.com/barnybug/savingsessions/blob/main/streamlit_app.py) that are able to calculate the reward you should get from a saving session based on past usage and usage over the saving period.

Expected behaviour

Add an estimated_reward_octopoints field as part of the opted-in session thats are provided on the event.octopus_energy_**_octoplus_saving_session_events sensor. This would populate AFTER the session using previous usage and usage over that period all of which is available through the API.

Use Case

Octopus takes a week plus to calculate this and it'd be nice to get a quick estimate on the value.

Confirmation

  • By submitting this feature request, you agree that you have read the documentation and confirmed it does not already exist
  • I am willing/able to help contribute to the solution of this feature
@JRascagneres JRascagneres added the enhancement New feature or request label Dec 8, 2023
@BottlecapDave
Copy link
Owner

BottlecapDave commented Dec 10, 2023

Hello and thanks for the feature request. I'm currently reworking on how data is retrieved based on some requests by OE along with some other features so I don't have time to implement this at the moment. I also personally don't see the need for it as it doesn't have an impact on automations and I can personally wait for the data to become available as I can't see it impacting any automations. However, if you would like it sooner and wish to add the feature yourself, I'm more than happy to accept a PR. However I would hold off until #597 and #533 are complete as it would rely on those.

The following acceptance criteria should be met

  1. Only calculate for joined saving sessions where the actual data isn't available
  2. We should not double process data required by both Show the last 10 days history for the next Saving Session period #533 and this, so we might need to save the target locally and share.
  3. The consumption data for the saving session should favour current consumption data if available and then falling back on previous consumption data
  4. The estimate should be saved locally and retrievd during updates as the consumption data will eventually become unavailable, potentially before OE give the correct reading, and we don't want to process the estimate every time we refresh the events
  5. This should all be done in the saving session coordinator

@BottlecapDave BottlecapDave added the More demand needed A feature that will be considered if there is more demand label Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request More demand needed A feature that will be considered if there is more demand
Projects
None yet
Development

No branches or pull requests

2 participants