Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Request: Thorium (Chromium fork) #2467

Closed
4 tasks done
musicalskele opened this issue Oct 17, 2023 · 4 comments
Closed
4 tasks done

App Request: Thorium (Chromium fork) #2467

musicalskele opened this issue Oct 17, 2023 · 4 comments

Comments

@musicalskele
Copy link

What is the name of the app?

Thorium

(Optional) Where is the app hosted?

main website is at https://thorium.rocks/
main repo is hosted at https://github.com/Alex313031/thorium
raspberry-pi builds hosted at https://github.com/Alex313031/Thorium-Raspi

About the app

Thorium, a Chromium-based browser, claims to offer significant speed improvements ranging from 8% to 38% when compared to the standard Chromium browser. While I haven't conducted comprehensive testing, I have observed enhanced performance on my Raspberry Pi in some areas. Perhaps it just needs tweaking.

One notable advantage of Thorium is the inclusion of several additional features not found in the regular Chromium browser. You can check these changes on the bottom of the this text which will have several links including a list of patches.

I ran a benchmark test using the default Chromium application that comes with Raspberry Pi OS (64-bit) on my Raspberry Pi 4 Rev 1.1, which operates at 2.0GHz with 2 GB of memory and a 720p resolution over VNC. Here are the benchmark results:

benchmark-chromium-summary
benchmarkchromium-detailed

I repeated the same benchmark using Thorium on the same OS and device, and here are the results for Thorium:

benchmark-thorium-summary
benchmark-thorium-detailed

A few things to note is the total memory usage was approximately 780MB on average with the default Chromium browser and averaged around 850MB with Thorium. Weirdly, Thorium had a quicker startup time and felt more responsive. It appeared to put less strain on the CPU, although I didn't measure this aspect.

While Thorium may have some areas where it performs slightly slower, I think it has some potential with the features it's got. As I have said perhaps the issue is that it hasn't been tweaked for the raspberry pi.

Unfortunately only supports arm64.
More details about the performance here:
https://thorium.rocks/performance
More details about the optimizations used here:
https://thorium.rocks/optimizations
List of all patches here:
https://github.com/Alex313031/Thorium/blob/main/infra/PATCHES.md

Confirmations

@github-actions
Copy link
Contributor

Hello there 👋
Thanks for submitting your first issue to the Pi-Apps project! We'll try to get back to you as soon as possible.
In the meantime, we encourage you join our Discord server, where you can ask any questions you might have.

Please respond as soon as possible if a Pi-Apps maintainer requests more information from you. Stale issues will be closed after a lengthy period of time with no response.

@Botspot
Copy link
Owner

Botspot commented Oct 17, 2023

VNC could be messing up your results. Browsers in particular will care about displaying to a real screen.

@theofficialgman
Copy link
Collaborator

theofficialgman commented Oct 17, 2023

I had a pretty lengthy response written to this but then my computer crashed for the first time in years so you get the sparknotes now...

Thorium (chromium fork) and Mercury (firefox fork) are from the same dev.
The benchmarking they do appears highly contrived and does not seem reproducible by independent third parties on modern hardware https://www.phoronix.com/review/mercury-firefox-perf.
Note that all benchmarks by the dev are performed on ancient an AMD x86_64 CPU.

Now the following is my opinion and interpretation:
I would consider these projects a cash grab at best and detrimental to the upstream projects at worst. Contributing patches that actually have meaningful improvements to performance is much more valuable than "oh lets turn on compiler optimizations, vroom vroom". Google and mozilla do test for performance and have their own (usually very good and valid) reasons for using the optimization flags that they do use when they do use them.

The one man show (22 year old) https://github.com/Alex313031 can't reasonably keep up with the security vulnerabilities that only increase in volume by the day and to be honest I don't see a reason to trust their builds (browsers can handle a lot of sensitive data).

TLDR: I'm personally opposed to this in pi-apps

@theofficialgman theofficialgman closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2023
@theofficialgman
Copy link
Collaborator

Brodie Robertson just make a video going over all of the concerns I brought up and more https://youtu.be/tR-dhc_SWBk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants