Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink folder structure #40

Open
Botffy opened this issue Jul 27, 2021 · 0 comments
Open

Rethink folder structure #40

Botffy opened this issue Jul 27, 2021 · 0 comments

Comments

@Botffy
Copy link
Owner

Botffy commented Jul 27, 2021

Currently mostly everything is just in the src root (except totally reusable components like TimeAgo).

@egkrly proposed a feature based system, and we do have multiple independent features:

  • stat pages (Bikes.vue, TimePage.vue etc, whose name could be standardised to *StatPage.vue)
  • adding rides (RideForm.vue, RideFormByScreenshot.vue, the celebration service)
  • the mostly static pages like InfoPage

ride-service.ts doesn't really play nice with this, especially since it reads and writes firestore data and also calculates celebrations (which it shouldn't). But it can be split into a "read rides from firestore" and "write ride to firestore" service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant