Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ESLint, work out rules together #38

Open
egkrly opened this issue Jul 27, 2021 · 0 comments
Open

Introduce ESLint, work out rules together #38

egkrly opened this issue Jul 27, 2021 · 0 comments
Assignees
Labels

Comments

@egkrly
Copy link
Contributor

egkrly commented Jul 27, 2021

So the problem is that the editor loves applying it's own rules while editing, for example, " characters for automatic imports.
It also loves to play with identation and other stuff like that.

We should at least agree on these things:

  • identation (I usually prefer tabs, but as I can see here you @Botffy used 2 spaces)
  • is line ending semicolons needed in ts files
  • typescript types - should it break the build if we don't pass at least any
  • maybe function complexity? (if we really wanna torture ourselves but in a beneficial way)
  • empty line on end of file

ESLint for TypeScript: https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin

In my opinion we should try out the default configuration first, with our own set of rules that we discuss here.

@egkrly egkrly added the tooling label Jul 27, 2021
Botffy added a commit that referenced this issue Jul 27, 2021
Solves part of #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants