Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize data types #175

Open
div5252 opened this issue Dec 13, 2020 · 0 comments
Open

Standardize data types #175

div5252 opened this issue Dec 13, 2020 · 0 comments

Comments

@div5252
Copy link

div5252 commented Dec 13, 2020

There are many places in the library where the data types aren't standardize, for eg. in the coordinate systems. For example, the size of long int i.e. 8 usually, varies from compiler to compiler, and so it could lead to an issue. You can see this here- https://godbolt.org/z/cEsMPP

So we should be using the std::int64_t/std::size_t by including the header file cstdint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant