Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception specifications and attributes to the required portion of code in FITS module #165

Open
gopi487krishna opened this issue Oct 11, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@gopi487krishna
Copy link
Collaborator

gopi487krishna commented Oct 11, 2020

Currently the FITS codebase does not have exception specifications for various member functions in FITS module. Providing them would not only improve the documentation associated with the code but would also provide safety guarantees to the various portions of FITS code base.

Note : Kindly refrain from using Dynamic Exception Specification as they have already been deprecated since C++11 http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/p0003r0.html

Major portions of code also require attribute specification for better compiler diagnostics ( and to promote good practices in using FITS code ) . Both C++11 and C++14 attributes ( standard ones ) are allowed.

More information on attribute-specifiers
https://en.cppreference.com/w/cpp/language/attributes
https://www.geeksforgeeks.org/attributes-in-c/

Solving this issue can probably help you understand the codebase a little faster!!

@gopi487krishna gopi487krishna added the good first issue Good for newcomers label Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant