Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong image dimensions written for recent tifffile #24

Open
votti opened this issue Dec 2, 2024 · 0 comments
Open

Wrong image dimensions written for recent tifffile #24

votti opened this issue Dec 2, 2024 · 0 comments

Comments

@votti
Copy link
Collaborator

votti commented Dec 2, 2024

It seems like recent tifffile versions lead to to_tiff not writing images with the correct dimension.

A reproducible example is added by extending the unittest to check for the correct image dimensions:

https://github.com/votti/xtiff/blob/799fe2fa5f6337030c63fdb5064f59bea6e7ddc0/tests/test_tiff.py#L25-L26

This failfs for tifffile-2024.9.20 but works for tifffile-2023.4.12.

Likely this causes the issue reported here: BodenmillerGroup/ImcSegmentationPipeline#144 (comment)

A workaround would be to explicitly pin the tifffile version

votti pushed a commit to votti/xtiff that referenced this issue Dec 2, 2024
More recent versions do not write the correct dimensions
as discussed in issue BodenmillerGroup#24
votti pushed a commit to votti/xtiff that referenced this issue Dec 2, 2024
More recent versions do not write the correct dimensions
as discussed in issue BodenmillerGroup#24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant