diff --git a/R-package/DESCRIPTION b/R-package/DESCRIPTION index fcb7545..aea9534 100644 --- a/R-package/DESCRIPTION +++ b/R-package/DESCRIPTION @@ -1,8 +1,8 @@ Package: agtboost Type: Package Title: Adaptive and Automatic Gradient Boosting Computations -Version: 0.9.2 -Date: 2021-11-09 +Version: 0.9.3 +Date: 2021-11-23 Author: Berent Ånund Strømnes Lunde Maintainer: Berent Ånund Strømnes Lunde Description: Fast and automatic gradient tree boosting designed diff --git a/R-package/cran-comments.md b/R-package/cran-comments.md index ffd935f..a1152a1 100644 --- a/R-package/cran-comments.md +++ b/R-package/cran-comments.md @@ -14,5 +14,40 @@ agtboost 0.9.2 (2021-11-09) * checking CRAN incoming feasibility ... NOTE Maintainer: 'Berent Ånund Strømnes Lunde ' +## rhub::check_for_cran check results + +on Fedora Linux, R-devel, clang, gfortran +0 errors | 0 warnings | 1 notes + +* checking installed package size ... NOTE + installed size is 8.0Mb + sub-directories of 1Mb or more: + libs 7.4Mb + +This is due to not re-including debugging information in Makevars, as specified by the CRAN policy and pointed out by Prof Brian Ripley. A shared-object (.so) is larger than perhaps necessary, but compliant with CRAN policies. + +## Changes in agtboost 0.9.3 +Following e-mail from Prof Brian Ripley: +"The CRAN policy contains +- Packages should not attempt to disable compiler diagnostics, nor to +remove other diagnostic information such as symbols in shared objects." +Thus, agtboost 0.9.3 re-includes debugging information. This leads to package being larger on some OS. + +------------------------------------------------------------------------ +agtboost 0.9.2 (2021-11-09) +------------------------------------------------------------------------ +## Test environments +* local darwin17 install, R 4.1.1 +* winbuilder +* devtools check +* rhub check_for_cran, check_on_solaris, check_with_sanitizers + +## R CMD check results + +0 errors | 0 warnings | 1 notes + +* checking CRAN incoming feasibility ... NOTE +Maintainer: 'Berent Ånund Strømnes Lunde ' + ## Changes in agtboost 0.9.2 Some patching of serialization/deserialization of model objects, along with new features for model training. A deprecation notice is included, and package should be smaller on some OS due to stripping debugging information. diff --git a/R-package/src/Makevars b/R-package/src/Makevars index 9644313..5b183b6 100644 --- a/R-package/src/Makevars +++ b/R-package/src/Makevars @@ -8,9 +8,3 @@ CXX_STD = CXX11 PKG_CPPFLAGS = -I../inst/include #PKG_CXXFLAGS = -std=c++11 - -## decrease size of libs/.so objects after build -strippedLib: $(SHLIB) - if test -e "/usr/bin/strip" & test -e "/bin/uname" & [[ `uname` == "Linux" ]] ; then /usr/bin/strip --strip-debug $(SHLIB); fi - -.phony: strippedLib