Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlocalised strings for non-English languages show up as localisation keys when the browser sends a non-English Accept-Language header, affecting both auto-detected and set-via-preference-pane webapp languages #631

Closed
akemin-dayo opened this issue Dec 14, 2024 · 1 comment · Fixed by #632
Labels
bug Something isn't working

Comments

@akemin-dayo
Copy link
Contributor

akemin-dayo commented Dec 14, 2024

Steps to reproduce

  • Use a browser that sends a non-English Accept-Language header. For instance, ja-JP or ja in my case. ※ You can also set this using Chromium DevTools.
  • Open a version of the webapp that contains commit e59d035. Both master (7392447) and stable 5.5 are affected, including the demo instance as of this writing. (Also affects my backport which includes the same commit, but that's not really relevant here.)
  • Open the side menu and notice that strings that unlocalised strings show up not in English, but in their key form.
  • Open the preference pane and change the language to English.
  • Now change it back to whatever language you had before. (※ Japanese in my case)
  • Previously untranslated keys will now show up correctly as English strings.
  • Refresh the webapp.
  • Observe that untranslated strings are in their key form again.

Expected result

  • Untranslated strings should appear as English strings, not as localisation keys.

Actual result

  • Localisation keys appear instead of English strings for untranslated strings.

Context

BlueMap Version: 7392447
※ Also affects the demo instance: https://bluecolored.de/bluemap/

Screenshots (JP)

image image image

Screenshots (KR)

image image image
@akemin-dayo akemin-dayo changed the title Unlocalised strings for non-English languages show up as localisation keys when the webapp language was automatically set based on browser language, instead of manually set via preference pane Unlocalised strings for non-English languages show up as localisation keys when the browser sends a non-English Accept-Language header, affecting both auto-detected and set-via-preference-pane webapp languages Dec 14, 2024
NikitaCartes added a commit to NikitaCartes-forks/BlueMap that referenced this issue Dec 14, 2024
@akemin-dayo
Copy link
Contributor Author

akemin-dayo commented Dec 15, 2024

Can confirm that #632 (ce7e477) fixes the issue.

@github-project-automation github-project-automation bot moved this to Planned (unordered) in TODO / Idea board Dec 15, 2024
@TBlueF TBlueF added the bug Something isn't working label Dec 15, 2024
@TBlueF TBlueF moved this from Planned (unordered) to Ready for next release in TODO / Idea board Dec 15, 2024
akemin-dayo pushed a commit to akemin-dayo/BlueMap that referenced this issue Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready for next release
Development

Successfully merging a pull request may close this issue.

2 participants