-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compat with ultraliser 0.4.0 #16
Comments
With 0.3.0 it works, but I get a
|
With 0.4.0 and playing with parameters, I get a seg fault straight away |
Ah this was already noticed here: #9 |
Just replace tyour code with this please:
|
@arnaudon If you're trying to update atlas-placement-hints to use ultraliser v0.4.0, the main difficulty might be updating the tests so that they pass. The current tests are hardcoded to use a very old version of ultraliser here: https://github.com/BlueBrain/atlas-placement-hints/blob/main/tests/distances/test_create_watertight_mesh.py#L20-L22 |
The command here does not work at all with latest module of ultraliser:
https://github.com/BlueBrain/atlas-placement-hints/blob/main/atlas_placement_hints/distances/create_watertight_mesh.py#L113
@marwan-abdellah , I'm not even sure ( I couldn't find changelog) on how to map the old/new options, could you give me a mapping? thanks!
The text was updated successfully, but these errors were encountered: