Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commonlib v4 #107

Merged
merged 6 commits into from
Jul 26, 2024
Merged

Commonlib v4 #107

merged 6 commits into from
Jul 26, 2024

Conversation

rvazarkar
Copy link
Contributor

Description

Updates commonlib to the beta v4 and fixes all api contract issues. Also implements ACL inheritance hashing

Motivation and Context

Big rewrite of CommonLib

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

urangel
urangel reviewed Jul 25, 2024
View reviewed changes
Sharphound.csproj Outdated Show resolved Hide resolved
juggernot325
juggernot325 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@juggernot325 juggernot325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here are straightforward enough that even I, someone with no C# experience, can understand them. Approved!

@rvazarkar rvazarkar merged commit 3fc5bdd into 2.X Jul 26, 2024
1 check passed
@rvazarkar rvazarkar deleted the commonlib_v4 branch July 26, 2024 21:05
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@urangel urangel urangel approved these changes

@juggernot325 juggernot325 juggernot325 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvazarkar @juggernot325 @urangel