Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update logic and web app #90

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

af001
Copy link

@af001 af001 commented Nov 27, 2024

Changes:

list-function-apps.go
list-web-apps.go

AZFunctionApp and AZWebapp do not correctly display neo4j entities due to the keyword checks failing; specifically functionapp and app. The kind attribute may contain more than one value separated by a comma.

Observed variations from AppServices:

functionapp,workflowapp
<class 'str'>

app,linux
<class 'str'>

functionapp,linux
<class 'str'>

Copy link

github-actions bot commented Nov 27, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@af001
Copy link
Author

af001 commented Nov 27, 2024

I have read the CLA Document and I hereby sign the CLA

ddlees added a commit to BloodHoundAD/CLA that referenced this pull request Nov 27, 2024
@af001
Copy link
Author

af001 commented Nov 27, 2024

recheck

@sircodemane
Copy link
Contributor

@StephenHinck @slokie-so for vis

@slokie-so
Copy link

BP-1173

@af001
Copy link
Author

af001 commented Dec 3, 2024

Update on this. I found some better documentation. It seems the logic I used is still good since it will attempt to split on the comma. Webapp would need an additional check for hyperV.

Kind Resource Type
app Windows Web app
app,linux Linux Web app
app,linux,container Linux Container Web app
hyperV Windows Container Web App
app,container,windows Windows Container Web App
app,linux,kubernetes Linux Web App on ARC
app,linux,container,kubernetes Linux Container Web App on ARC
functionapp Function Code App
functionapp,linux Linux Consumption Function app
functionapp,linux,container,kubernetes Function Container App on ARC
functionapp,linux,kubernetes Function Code App on ARC

Ref: https://github.com/Azure/app-service-linux-docs/blob/master/Things_You_Should_Know/kind_property.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants