Refactor NumericalData #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relocate and refactor with base class and FD specific class
FaceData is a mixin for NumericalData. Its responsibility is to keep track of all numerical mesh face data, and lazily compute face data arrays- only when demanded. Its numerical arrays can be used for general purposes: face load computations, face stresses, Natural Force Density solvers, ...
Change FDNumericalData from dataclass into regular class with lazy calculation of property variables. Implicit recalculation of dependent variables. Add shorthand aliases to numerical arrays.
Formalize lazy evaluation into a decorator. Add matrices to FDNumericalData.
Change result location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change FDNumericalData from dataclass into regular class with lazy calculation of property variables.
Implicit recalculation of dependent variables. Add shorthand aliases to numerical arrays.
Add FaceData mixin for NumericalData.
Its responsibility is to keep track of all numerical mesh face arrays, and lazily compute them on demand.
Its arrays can be used for general purposes: face load computation, face stresses, Natural Force Density solver, ...