Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure brjs micro libraries have travis builds #1641

Open
thecapdan opened this issue Jan 25, 2016 · 4 comments
Open

Ensure brjs micro libraries have travis builds #1641

thecapdan opened this issue Jan 25, 2016 · 4 comments

Comments

@thecapdan
Copy link
Contributor

thecapdan commented Jan 25, 2016

Some micro libs don't have a travis build and aren't using npm. browser-modules, keyboard-events (possibly more)

@thecapdan
Copy link
Contributor Author

browser module is done. PR for keyboard-events here: BladeRunnerJS/keyboard-event#1

@dchambers
Copy link
Contributor

@thecapdan, feedback available in keyboard-events.

@thecapdan
Copy link
Contributor Author

looks like there's an open bug when running tests with karma-jasmine, "jasmineRequire is not a function". Will switch see if i can fix it, if not, will switch to mocha

@dchambers
Copy link
Contributor

looks like there's an open bug when running tests with karma-jasmine, "jasmineRequire is not a function". Will switch see if i can fix it, if not, will switch to mocha

Yes, I think in general having all of our libraries use identical config is a good idea. I'd personally also switch it over to CommonJS and use browserify too, even though it's tiny, just to keep everything consistent.

@thecapdan thecapdan changed the title Ensure brjs micro libraries have travis builds Ensure brjs micro libraries have travis builds using sauce labs Feb 8, 2016
@thecapdan thecapdan changed the title Ensure brjs micro libraries have travis builds using sauce labs Ensure brjs micro libraries have travis builds Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants