Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding your code #41

Open
tzak902 opened this issue Sep 20, 2020 · 1 comment
Open

Question regarding your code #41

tzak902 opened this issue Sep 20, 2020 · 1 comment

Comments

@tzak902
Copy link

tzak902 commented Sep 20, 2020

Hi,

Please check the following code from BitcoinECDSA.php line 101

$table = [ '1','2','3','4','5','6','7','8','9','A','B','C','D', 'E','F','G','H','J','K','L','M','N','P','Q','R','S','T','U','V','W', 'X','Y','Z','a','b','c','d','e','f','g','h','i','j','k','m','n','o', 'p','q','r','s','t','u','v','w','x','y','z' ];

Why the capital "i" and capital "o" also number zero are missing?

@rgex
Copy link
Contributor

rgex commented Sep 21, 2020

See this page: https://en.bitcoin.it/wiki/Base58Check_encoding
Supposedly this was done in order to avoid confusing a zero with an O and an O with an o

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants