Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Version checking & notification #314

Open
utdrmac opened this issue May 2, 2017 · 9 comments
Open

Feature Request: Version checking & notification #314

utdrmac opened this issue May 2, 2017 · 9 comments

Comments

@utdrmac
Copy link
Contributor

utdrmac commented May 2, 2017

Lots of changes are being made to this bot (Yay!) but subscribing to every issue is cluttering up my Inbox (Boo!). I'm not sure if I can subscribe to only "releases" or only to be notified when commits/merges on/to the master branch happen.

To that effect, I would like to see a daily/weekly version checker that simply prints a NOTE in the web gui and optionally, sends a notification using the new notifications additions that a new version is available.

@Evanito
Copy link
Member

Evanito commented May 2, 2017

Theoretically possible using a version file and a check between the local and remote versions.

@rnevet
Copy link
Collaborator

rnevet commented May 3, 2017 via email

@laxdog
Copy link
Collaborator

laxdog commented May 3, 2017

Should probably be done through Travis if you want it automated.

@utdrmac
Copy link
Contributor Author

utdrmac commented May 3, 2017

Version checking should be related to master commits. A thread/timer should check once a day/week/ that the current checkout is different from the current master.

@rnevet
Copy link
Collaborator

rnevet commented May 3, 2017

We could check with a git command in the python script, if git is behind, however this will only work if the bot is running from a git folder and not a plain copy.

@utdrmac
Copy link
Contributor Author

utdrmac commented May 3, 2017

Ah yes, if someone downloads the .zip/.tgz, there won't be any git-related stuff. So I guess there would need to be a version.txt file with the current commit hash that checks against the master branch copy at github.com?

@laxdog
Copy link
Collaborator

laxdog commented Aug 4, 2017

I've started some work on this. I'm adding a packaging branch where I'm hoping to address versioning, PyPi support and Travis builds with testing. Still a long way off, but it's being looked at.

@laxdog laxdog self-assigned this Aug 4, 2017
@Evanito
Copy link
Member

Evanito commented Mar 18, 2018

We could move to a tag system and keep everything on the github side.
Compare the local tags to the remote tags, and notify if a discrepancy is found.

Getting remote tags: https://mirrors.edge.kernel.org/pub/software/scm/git/docs/git-ls-remote.html

@ghost ghost assigned Evanito Apr 6, 2018
@ghost ghost added In Progress and removed Reviewed labels Apr 6, 2018
@Evanito Evanito mentioned this issue Apr 6, 2018
12 tasks
@Evanito
Copy link
Member

Evanito commented Apr 6, 2018

Just made a rudimentary solution, check it out #623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants