Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ffmpeg.cpp #3283

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Update ffmpeg.cpp #3283

merged 1 commit into from
Sep 4, 2024

Conversation

ProtagNeptune
Copy link

The option -vsync is deprecated now, so it should use -fps_mode instead.
https://superuser.com/a/1759791

The option `-vsync` is deprecated now, so it should use `-fps_mode` instead.
@ProtagNeptune ProtagNeptune mentioned this pull request Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 32.63%. Comparing base (eac529a) to head (c9dbec1).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #3283    +/-   ##
=========================================
  Coverage    32.63%   32.63%            
=========================================
  Files          384      384            
  Lines        22373    22373            
  Branches      3531     3532     +1     
=========================================
  Hits          7301     7301            
+ Misses       15071    14955   -116     
- Partials         1      117   +116     

Copy link
Owner

@Bionus Bionus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@Bionus Bionus merged commit 4e28e10 into Bionus:develop Sep 4, 2024
10 of 12 checks passed
@ProtagNeptune ProtagNeptune deleted the patch-1 branch September 5, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants