-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Site2Target #3666
Comments
Thanks for submitting your package. We are taking a quick The DESCRIPTION file for this package is:
|
When i try to R CMD build your package I'm getting the following ERROR
|
Hello, I got this error but I assumed it is about pandoc versioning. I could make .html file without any problem from .Rmd file. Do you know what is the problem? Thank you, |
I think you can just do |
Thank you very much! that solved the problem. Now I don't get error or warning in check and BiocCheck. now my problem is that I cannot push a new version to the Bioconductor. I do: git remote add origin https://github.com/fls-bioinformatics-core/Site2Target.git "error: Could not fetch upstream" It seems " [email protected]:packages/Site2Target" does not exists. Should I make a new issue and start from beginning? |
it is not yet on bioconductor. this is still in the preview stage. I will check your github repo for the updates soon |
I'll move this forward to building but please correct the following before an indepth review Please don't use Please also provide an |
Thank you for your reply. Strangely for my previous package the export part has been taken care by Roxygen but not for this one. I will do it. |
If you put the proper import / importFrom / export lines in documentation, maybe you just need to run Even just a text describing what you say here, a reference that its from GEO, so we know it can be distributed. Ideally if someone wanted to generate their own they know where to get started |
Your package has been added to git.bioconductor.org to continue the IMPORTANT: Please read this documentation for setting Bioconductor utilized your github ssh-keys for git.bioconductor.org |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. On one or more platforms, the build results were: "ERROR". Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
Thank you! I fixed your notes and the error which was the gitignore thing. I did git remote add upstream [email protected]:packages/Site2Target.git git remote -v git fetch --all I see: which is correct but the rest of things do not work git merge upstream/mster Can you help with this? What is the problem what should I write? |
Bioconductor does not have a main or master branch. Bioconductor uses devel as the main branch. Please see http://contributions.bioconductor.org/git-version-control.html#new-package-workflow step 5 explains pushes to a branch that has a different name |
Thank you! but I am still stuck. I think it is different from my previous package. Can you help me: This is right:
This seems right:
From here everything does not work:
|
It looks like your default branch is named origin? May I assume the local branch you are on matches that? |
Thank you very much! When I go to Site2Target github it has only one branch and it is called Origin. Whatever I do I get error
|
Can you do as it suggests and do a git pull and git pull upstream |
Thank you! I am still stuck. git push upstream devel git branch
git pull git pull upstream git push upstream origin:devel |
per your output there, you are on a branch called devel. Whatever branch it says your on you should use in your call. |
I do not have devel on my local (origin) repository. It just have one branch. The devel one is on the upstream. Something is wrong and i was trying to correct it to do: git push upstream origin:devel |
Received a valid push on git.bioconductor.org; starting a build for commit id: 972876c8e5c20524025dde329a406ee29195a181 |
Dear Package contributor, This is the automated single package builder at bioconductor.org. Your package has been built on the Bioconductor Single Package Builder. Congratulations! The package built without errors or warnings Please see the build report for more details. The following are build products from R CMD build on the Single Package Builder: Links above active for 21 days. Remember: if you submitted your package after July 7th, 2020, |
A reviewer has been assigned to your package for an indepth review. |
Package 'Site2Target' ReviewThank you for submitting your package to Bioconductor. The package passed check and build. However there are several things need to be fixed. Please try to answer the comments line by line when you are ready for a second review. The DESCRIPTION file
General package development
R code
Documentation
|
Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor
Confirm the following by editing each check box to '[x]'
I understand that by submitting my package to Bioconductor,
the package source and all review commentary are visible to the
general public.
I have read the Bioconductor Package Submission
instructions. My package is consistent with the Bioconductor
Package Guidelines.
I understand Bioconductor Package Naming Policy and acknowledge
Bioconductor may retain use of package name.
I understand that a minimum requirement for package acceptance
is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
Passing these checks does not result in automatic acceptance. The
package will then undergo a formal review and recommendations for
acceptance regarding other Bioconductor standards will be addressed.
My package addresses statistical or bioinformatic issues related
to the analysis and comprehension of high throughput genomic data.
I am committed to the long-term maintenance of my package. This
includes monitoring the support site for issues that users may
have, subscribing to the bioc-devel mailing list to stay aware
of developments in the Bioconductor community, responding promptly
to requests for updates from the Core team in response to changes in
R or underlying software.
I am familiar with the Bioconductor code of conduct and
agree to abide by it.
I am familiar with the essential aspects of Bioconductor software
management, including:
months, for bug fixes.
(optionally via GitHub).
For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.
The text was updated successfully, but these errors were encountered: