Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beachmat.tiledb #3651

Closed
10 tasks done
LTLA opened this issue Nov 8, 2024 · 15 comments
Closed
10 tasks done

beachmat.tiledb #3651

LTLA opened this issue Nov 8, 2024 · 15 comments
Assignees
Labels
3a. accepted will be ingested into Bioconductor daily builder for distribution WARNINGS

Comments

@LTLA
Copy link

LTLA commented Nov 8, 2024

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Hi @LTLA

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: beachmat.tiledb
Version: 0.99.0
Date: 2024-11-07
Title: beachmat bindings for TileDB-backed matrices
Description: 
    Extends beachmat to initialize tatami matrices from TileDB-backed arrays.
    This allows C++ code in downstream packages to directly call the TileDB C/C++ library to access array data,
    without the need for block processing via DelayedArray.
    Developers only need to import this package to automatically extend the capabilities of beachmat::initializeCpp to TileDBArray instances.
Authors@R: person("Aaron", "Lun", role = c("aut", "cre"), email = "[email protected]")
Imports: 
    methods,
    beachmat,
    tiledb,
    TileDBArray,
    DelayedArray,
    Rcpp
Suggests: 
    testthat,
    BiocStyle,
    knitr,
    rmarkdown,
    Matrix
LinkingTo: 
    Rcpp, 
    assorthead,
    beachmat
biocViews:
    DataRepresentation,
    DataImport,
    Infrastructure
License: GPL-3
NeedsCompilation: yes
VignetteBuilder: knitr
SystemRequirements: C++17
RoxygenNote: 7.3.2
Encoding: UTF-8

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label Nov 8, 2024
@lshep lshep added the pre-check passed pre-review performed and ready to be added to git label Nov 25, 2024
@bioc-issue-bot
Copy link
Collaborator

Your package has been added to git.bioconductor.org to continue the
pre-review process. A build report will be posted shortly. Please
fix any ERROR and WARNING in the build report before a reviewer is
assigned or provide a justification on why you feel the ERROR or
WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting
up remotes to push to git.bioconductor.org. All changes should be
pushed to git.bioconductor.org moving forward. It is required to push a
version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org
access. To manage keys and future access you may want to active your
Bioconductor Git Credentials Account

@bioc-issue-bot bioc-issue-bot added pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean and removed 1. awaiting moderation submitted and waiting clearance to access resources pre-check passed pre-review performed and ready to be added to git labels Nov 25, 2024
@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "WARNINGS".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 24.04.1 LTS): beachmat.tiledb_0.99.0.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/beachmat.tiledb to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@lshep lshep added 2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place and removed pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean labels Nov 27, 2024
@bioc-issue-bot
Copy link
Collaborator

A reviewer has been assigned to your package for an indepth review.
Please respond accordingly to any further comments from the reviewer.

@PeteHaitch
Copy link

PeteHaitch commented Dec 16, 2024

Hi Aaron,

All looks good with only a few requests and queries.

Cheers,
Pete


Queries

  • R_ENVIRON_USER=~/.Renviron.bioc R CMD check beachmat.tiledb_0.99.0.tar.gz reports the following. Frankly I don't know exactly what this means or requires, but can it be avoided/quietened?
* checking compilation flags in Makevars ... NOTE
Package has both ‘src/Makevars.in’ and ‘src/Makevars’.
Installation with --no-configure' is unlikely to work.  If you intended
‘src/Makevars’ to be used on Windows, rename it to ‘src/Makevars.win’
otherwise remove it.  If ‘configure’ created ‘src/Makevars’, you need a
‘cleanup’ script.
  • BiocCheck() reports ! WARNING: Package files exceed the 5MB size limit.. I'm guessing this is unavoidable?

Required

  • Please devtools::document() to ensure documentation is up-to-date.

Recommended

  • Consider adding BugReports to DESCRIPTION.
  • Consider adding a NEWS file.

@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: ddcfd81ade5274bd581ff8eb0ebb82ffca57ef1c

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "WARNINGS".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 24.04.1 LTS): beachmat.tiledb_0.99.1.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/beachmat.tiledb to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@LTLA
Copy link
Author

LTLA commented Dec 17, 2024

Done with the exception of the the install size. The binaries produced by GCC with R's defaults come with loads of unnecessary symbols and I don't know how to reliably remove them on a per-package level. I think one would need to enable LTO in the R installation.

@PeteHaitch
Copy link

PeteHaitch commented Dec 17, 2024

Thanks, Aaron.

@PeteHaitch PeteHaitch added the 3a. accepted will be ingested into Bioconductor daily builder for distribution label Dec 17, 2024
@bioc-issue-bot
Copy link
Collaborator

Your package has been accepted. It will be added to the
Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor
community. If you are interested in becoming a Bioconductor package
reviewer, please see Reviewers Expectations.

@PeteHaitch PeteHaitch removed the 2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place label Dec 17, 2024
@LTLA
Copy link
Author

LTLA commented Jan 1, 2025

Can someone add this to the build system? Normally I'd get the 3b notification by now.

@PeteHaitch
Copy link

I can't and assume it'll have to be once someone from @Bioconductor/core is back online

@vjcitn
Copy link
Collaborator

vjcitn commented Jan 2, 2025

Noted.

@lshep
Copy link
Contributor

lshep commented Jan 2, 2025

sorry I was away for the holiday for a week and half. I'll look at processing accepted packages today or tomorrow at the absolute latest.

@lshep
Copy link
Contributor

lshep commented Jan 2, 2025

The default branch of your GitHub repository has been added to Bioconductor's
git repository as branch devel.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/LTLA.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/
https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("beachmat.tiledb"). The package 'landing page' will be created at

https://bioconductor.org/packages/beachmat.tiledb

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.

@lshep lshep closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3a. accepted will be ingested into Bioconductor daily builder for distribution WARNINGS
Projects
None yet
Development

No branches or pull requests

5 participants