Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SurfR #3105

Closed
10 tasks done
auroramaurizio opened this issue Aug 9, 2023 · 151 comments
Closed
10 tasks done

SurfR #3105

auroramaurizio opened this issue Aug 9, 2023 · 151 comments
Assignees
Labels
3a. accepted will be ingested into Bioconductor daily builder for distribution OK

Comments

@auroramaurizio
Copy link

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Hi @auroramaurizio

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: SurfR
Type: Package
Title: Surface Protein Prediction and Identification
Version: 0.99.0
Authors@R:c(person("Aurora", "Maurizio", email="[email protected]", role = c("aut","cre")),
 person("Anna Sofia", "Tascini", email="[email protected]", role = c("aut", "ctb")))
Description: Identify Surface Protein coding genes from a list of candidates.
   Systematically download data from GEO and TCGA or use your own data. 
   Perform DGE on bulk RNAseq data. 
   Perform Meta-analysis. Descriptive enrichment analysis and plots.
License: GPL-3 + file LICENSE
Encoding: UTF-8
LazyData: false
biocViews: Software, Sequencing, RNASeq, GeneExpression, Transcription, DifferentialExpression, 
 PrincipalComponent, GeneSetEnrichment, Pathways, BatchEffect,
 FunctionalGenomics, Visualization, DataImport
VignetteBuilder: knitr
RoxygenNote: 7.2.3
Imports:
  httr,
  SPsimSeq,
  DESeq2,
  edgeR,
  rio,
  openxlsx,
  stringr,
  rhdf5,
  ggplot2,
  ggrepel,
  stats,
  magrittr,
  assertr,
  tidyr,
  dplyr,
  TCGAbiolinks,
  biomaRt,
  metaRNASeq,
  enrichR,
  scales,
  venn,
  gridExtra,
  SummarizedExperiment,
  knitr,
  grDevices, 
  graphics, 
  utils

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label Aug 9, 2023
@vjcitn vjcitn added pre-check passed pre-review performed and ready to be added to git and removed 1. awaiting moderation submitted and waiting clearance to access resources labels Sep 2, 2023
@bioc-issue-bot
Copy link
Collaborator

A reviewer has been assigned to your package. Learn what to expect
during the review process.

IMPORTANT: Please read this documentation for setting
up remotes to push to git.bioconductor.org. It is required to push a
version bump to git.bioconductor.org to trigger a new build.

Bioconductor utilized your github ssh-keys for git.bioconductor.org
access. To manage keys and future access you may want to active your
Bioconductor Git Credentials Account

@bioc-issue-bot bioc-issue-bot added 2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place and removed pre-check passed pre-review performed and ready to be added to git labels Sep 6, 2023
@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build
System:
ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/SurfR to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: 8d44c6b00562d4cee1af41ffbc00842a899434c5

@auroramaurizio
Copy link
Author

Dear @PeteHaitch,

Thank you for the feedback.

We fixed the linux-platform issue in the vignette and submitted the updated version.

We have tested the package on a local Mac OS computer and the R CMD check succeeded. At the end of this message we report the sessionInfo().
Unfortunately, we could not reproduce the mac-related error highlighted in the lconway BUILD SRC output: "Rhdf5lib was not compiled with support for the S3 VFD". We read the chat between you and a former package submitter addressing the same topic #2753 (and checked the package source) as well as several posts by Mike Smith such as https://support.bioconductor.org/p/9134972/#9153888. It seems more like a macOS-Rhdf5 related problem. What's your advice?

Best wishes,

Aurora and Anna Sofia

sessionInfo()
R version 4.3.1 (2023-06-16)
Platform: x86_64-apple-darwin20 (64-bit)
Running under: macOS Monterey 12.6.3

Matrix products: default
BLAS: /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib
LAPACK: /Library/Frameworks/R.framework/Versions/4.3-x86_64/Resources/lib/libRlapack.dylib; LAPACK version 3.11.0

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

time zone: Europe/Rome
tzcode source: internal

attached base packages:
[1] stats graphics grDevices utils datasets methods base

other attached packages:
[1] stringr_1.5.0 SPsimSeq_1.10.0 SurfR_0.99.0 BiocManager_1.30.22

loaded via a namespace (and not attached):
[1] splines_4.3.1 bitops_1.0-7 filelock_1.0.2 tibble_3.2.1 cellranger_1.1.0
[6] preprocessCore_1.62.1 XML_3.99-0.14 rpart_4.1.19 lifecycle_1.0.3 fastcluster_1.2.3
[11] edgeR_3.42.4 doParallel_1.0.17 lattice_0.21-8 MASS_7.3-60 backports_1.4.1
[16] magrittr_2.0.3 openxlsx_4.2.5.2 limma_3.56.2 Hmisc_5.1-0 rmarkdown_2.24
[21] zip_2.3.0 DBI_1.1.3 ade4_1.7-22 abind_1.4-5 zlibbioc_1.46.0
[26] rvest_1.0.3 GenomicRanges_1.52.0 purrr_1.0.2 metaRNASeq_1.0.7 BiocGenerics_0.46.0
[31] RCurl_1.98-1.12 phyloseq_1.44.0 nnet_7.3-19 WriteXLS_6.4.0 rappdirs_0.3.3
[36] GenomeInfoDbData_1.2.10 IRanges_2.34.1 S4Vectors_0.38.1 ggrepel_0.9.3 vegan_2.6-4
[41] venn_1.11 fitdistrplus_1.1-11 permute_0.9-7 codetools_0.2-19 DelayedArray_0.26.7
[46] xml2_1.3.5 tidyselect_1.2.0 TCGAbiolinksGUI.data_1.20.0 matrixStats_1.0.0 stats4_4.3.1
[51] BiocFileCache_2.8.0 dynamicTreeCut_1.63-1 base64enc_0.1-3 jsonlite_1.8.7 multtest_2.56.0
[56] Formula_1.2-5 survival_3.5-7 iterators_1.0.14 foreach_1.5.2 tools_4.3.1
[61] progress_1.2.2 rio_0.5.30 Rcpp_1.0.11 glue_1.6.2 gridExtra_2.3
[66] admisc_0.33 xfun_0.40 mgcv_1.9-0 DESeq2_1.40.2 MatrixGenerics_1.12.3
[71] GenomeInfoDb_1.36.2 dplyr_1.1.3 fastmap_1.1.1 rhdf5filters_1.12.1 fansi_1.0.4
[76] digest_0.6.33 R6_2.5.1 colorspace_2.1-0 GO.db_3.17.0 biomaRt_2.56.1
[81] RSQLite_2.3.1 utf8_1.2.3 tidyr_1.3.0 generics_0.1.3 data.table_1.14.8
[86] prettyunits_1.1.1 httr_1.4.7 htmlwidgets_1.6.2 S4Arrays_1.0.6 pkgconfig_2.0.3
[91] gtable_0.3.4 blob_1.2.4 impute_1.74.1 SingleCellExperiment_1.22.0 XVector_0.40.0
[96] htmltools_0.5.6 biomformat_1.28.0 scales_1.2.1 Biobase_2.60.0 png_0.1-8
[101] enrichR_3.2 knitr_1.43 rstudioapi_0.15.0 tzdb_0.4.0 reshape2_1.4.4
[106] rjson_0.2.21 checkmate_2.2.0 nlme_3.1-163 curl_5.0.2 cachem_1.0.8
[111] rhdf5_2.44.0 parallel_4.3.1 foreign_0.8-84 AnnotationDbi_1.62.2 pillar_1.9.0
[116] grid_4.3.1 vctrs_0.6.3 dbplyr_2.3.3 cluster_2.1.4 htmlTable_2.4.1
[121] evaluate_0.21 TCGAbiolinks_2.28.3 readr_2.1.4 mvtnorm_1.2-3 cli_3.6.1
[126] locfit_1.5-9.8 compiler_4.3.1 rlang_1.1.1 crayon_1.5.2 assertr_3.0.0
[131] plyr_1.8.8 forcats_1.0.0 stringi_1.7.12 WGCNA_1.72-1 BiocParallel_1.34.2
[136] munsell_0.5.0 Biostrings_2.68.1 Matrix_1.6-1 hms_1.1.3 bit64_4.0.5
[141] ggplot2_3.4.3 Rhdf5lib_1.22.0 KEGGREST_1.40.0 SummarizedExperiment_1.30.2 haven_2.5.3
[146] igraph_1.5.1 memoise_2.0.1 bit_4.0.5 readxl_1.4.3 downloader_0.4
[151] ape_5.7-1

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build
System:
Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.1.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/SurfR to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: acf8a50bc5fd393b36a571b2be58056de10d8db5

1 similar comment
@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: acf8a50bc5fd393b36a571b2be58056de10d8db5

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ABNORMAL".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build
System:
ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/SurfR to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: 5a0f525af984db421c28f2809f6416373ea09cf4

1 similar comment
@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: 5a0f525af984db421c28f2809f6416373ea09cf4

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ABNORMAL".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build
System:
ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/SurfR to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build
System:
ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/SurfR to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Build System.

On one or more platforms, the build results were: "ERROR, skipped".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Bioconductor Build
System:
Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.1.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/SurfR to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@auroramaurizio
Copy link
Author

Dear @PeteHaitch,
It seems there might be a discrepancy between the package version in the build report and the actual version in the repositories.
Looking at the build report we noticed that the check is still made on package version 0.99.1 while the current version is 0.99.3.
We pushed the latest version on both origin and upstream repos.
Cloning https://git.bioconductor.org/packages/SurfR.git we see that everithing is up to date: the corrections have been implemented (removing SurfR.Proj file and updating .gitignore) and the version in DESCRIPTION is the latest 0.99.3.
Only the check on the build report is made on the old version 0.99.1.

Thank you for your attention to this matter.

Best,
Aurora and Anna Sofia

@PeteHaitch
Copy link

@lshep any idea about why an old version is getting picked up by the build system (see #3105 (comment))

@lshep
Copy link
Contributor

lshep commented Sep 12, 2023

It looks like something odd is going in; in particular also with the double build report kick off. yet we don't see this with other repositories. how exactly are you making changes and pushing to git.bioconductor.org?

@auroramaurizio
Copy link
Author

auroramaurizio commented Sep 12, 2023

Dear @lshep,
Thank you for your quick reply.

Here the commands:

git remote -v

#origin [email protected]:auroramaurizio/SurfR.git (fetch)
#origin [email protected]:auroramaurizio/SurfR.git (push)
#upstream [email protected]:packages/SurfR.git (fetch)
#upstream [email protected]:packages/SurfR.git (push)

git fetch --all
git merge origin/master
git merge upstream/master
git add .
git commit -m "bumped the package version 0.99.3"
git push origin master
git push upstream master
git push upstream master:devel

I think the double report kick off is due to the fact that I pushed to master instead of devel at first.
I got this message in the last commit:

git push upstream master

#Counting objects: 5, done.
#Delta compression using up to 8 threads.
#Compressing objects: 100% (3/3), done.
#Writing objects: 100% (3/3), 302 bytes | 0 bytes/s, done.
#Total 3 (delta 2), reused 0 (delta 0)
#remote: Use of 'master' branch is deprecated on git.bioconductor.org;
#remote: Access to 'master' will eventually be revoked.
#remote: Please use 'devel' to update Bioconductor devel version.
#remote: See: http://contributions.bioconductor.org/branch-rename-faqs.html
#To [email protected]:packages/SurfR.git
#acf8a50..5a0f525 master -> master

git push upstream master:devel

#Total 0 (delta 0), reused 0 (delta 0)
#To [email protected]:packages/SurfR.git
#acf8a50..5a0f525 master -> devel

I'll move to devel as prompt here http://contributions.bioconductor.org/branch-rename-faqs.html.
Hope it solves the issue.

Best,
Aurora

@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: dc2aeb9c0cc5388ffd8ecf954edc8e0c82a886f3

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "skipped, ERROR".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
ERROR before build products produced.

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/SurfR to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: 4ffb93e5be3264c085214b6e04ac4bc526370948

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "WARNINGS".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.50.tar.gz
macOS 12.7.1 Monterey: SurfR_0.99.50.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/SurfR to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: f19045f087609f9430b3f8419f8e120266390516

@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: eb28c6d948eacdd1148397aea0f00817127ce3af

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "WARNINGS".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
macOS 12.7.1 Monterey: SurfR_0.99.51.tar.gz
Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.51.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/SurfR to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "WARNINGS".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.52.tar.gz
macOS 12.7.1 Monterey: SurfR_0.99.52.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/SurfR to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: 1810b382eb38098ebf18a4c92cdbf4092a7a6c2b

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings
on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
macOS 12.7.1 Monterey: SurfR_0.99.53.tar.gz
Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.53.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/SurfR to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@auroramaurizio
Copy link
Author

Hi @ococrook, I'm happy to tell you that the report is now successful on both Mac and Linux builders!

@ococrook
Copy link

Hi @auroramaurizio ,

Sorry this has been a slow proces, a final few things before we can finish this off:

Can you make the version of the package match between the NEWS file and Description?

Can you switch to the Biocstyle for the vignette?

youll need to add the following to the header

output:
  BiocStyle::html_document:
    toc_float: true

@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: e965fd3ec11457c74e55a8863c55950fff8f6c5e

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings
on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
macOS 12.7.1 Monterey: SurfR_0.99.54.tar.gz
Linux (Ubuntu 22.04.2 LTS): SurfR_0.99.54.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/SurfR to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@auroramaurizio
Copy link
Author

Hi @ococrook,
I updated the vignette and the NEWS file as per your suggestions.
Thank you! Aurora

@auroramaurizio
Copy link
Author

Dear @ococrook,
I hope you're doing well.
Do you think there is a chance SurfR package can be included in the upcoming April 2024 Bioconductor 3.19 release? Please let me know if I should do anything to proceed.
Thank you,
Best,
Aurora

@ococrook ococrook added 3a. accepted will be ingested into Bioconductor daily builder for distribution and removed 2. review in progress assign a reviewer and a more thorough review of package code and documentation taking place labels Feb 13, 2024
@bioc-issue-bot
Copy link
Collaborator

Your package has been accepted. It will be added to the
Bioconductor nightly builds.

Thank you for contributing to Bioconductor!

Reviewers for Bioconductor packages are volunteers from the Bioconductor
community. If you are interested in becoming a Bioconductor package
reviewer, please see Reviewers Expectations.

@ococrook
Copy link

Hi Aurora,

Not sure what happen but I recall trying to accept this package several times now. Hopefully, it gone through now.

@auroramaurizio
Copy link
Author

Thank you very much Oliver!
I wish you a great day,
Aurora

@lshep
Copy link
Contributor

lshep commented Feb 14, 2024

The default branch of your GitHub repository has been added to Bioconductor's
git repository as branch devel.

To use the git.bioconductor.org repository, we need an 'ssh' key to associate with your github user name. If your GitHub account already has ssh public keys (https://github.com/auroramaurizio.keys is not empty), then no further steps are required. Otherwise, do the following:

  1. Add an SSH key to your github account
  2. Submit your SSH key to Bioconductor

See further instructions at

https://bioconductor.org/developers/how-to/git/

for working with this repository. See especially

https://bioconductor.org/developers/how-to/git/new-package-workflow/
https://bioconductor.org/developers/how-to/git/sync-existing-repositories/

to keep your GitHub and Bioconductor repositories in sync.

Your package will be included in the next nigthly 'devel' build (check-out from git at about 6 pm Eastern; build completion around 2pm Eastern the next day) at

https://bioconductor.org/checkResults/

(Builds sometimes fail, so ensure that the date stamps on the main landing page are consistent with the addition of your package). Once the package builds successfully, you package will be available for download in the 'Devel' version of Bioconductor using BiocManager::install("SurfR"). The package 'landing page' will be created at

https://bioconductor.org/packages/SurfR

If you have any questions, please contact the bioc-devel mailing list (https://stat.ethz.ch/mailman/listinfo/bioc-devel); this issue will not be monitored further.

@lshep lshep closed this as completed Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3a. accepted will be ingested into Bioconductor daily builder for distribution OK
Projects
None yet
Development

No branches or pull requests

7 participants