Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To authors: check your vignettes for unstated dependencies #32

Open
seandavi opened this issue Jun 11, 2019 · 0 comments
Open

To authors: check your vignettes for unstated dependencies #32

seandavi opened this issue Jun 11, 2019 · 0 comments

Comments

@seandavi
Copy link
Collaborator

Please go through and do devtools::check() on your workshop packages. Look for notes like:

❯ checking for unstated dependencies in vignettes ... NOTE
  '::' or ':::' import not declared from: ‘summarytools’
  'library' or 'require' calls not declared from:
    ‘UpSetR’ ‘ggplot2’

While this is a NOTE on your system, installing into a system that does not have summarytools installed, for example, will fail when rebuilding the vignette. The solution to remove the NOTE above is to add summarytools, UpSetR, and ggplot2 to the Suggests section of the DESCRIPTION file.

Doing this will save a lot of headaches for us downstream.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant