-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could you provide a shadowJar version of the Bing API SDK #206
Comments
Hi, thank you for the suggestion! We won't provide a version-specific shadow jar. Could you try pom_for_shadow_jar.xml to package it? It works well on my local. If you encounter any other issues please feel free to ask here. |
Thank you very much for your attention. |
Just updated pom_for_shadow_jar.xml to relocate all dependencies. Noticed that the META-INF/cxf/bus-extensions.txt file aren't aggregated properly and loaded properly and the class names cannot be relocated by ServicesResourceTransformer. I added my-bus-extensions.txt to replace it. Could you try it again? |
Hi, thank you for pointing out these issues. I updated the pom to relocate all packages. For META-INF/cxf/org.apache.cxf.bus.factory, I don't find a transformer to process it. Looks like cxf is so special and it's not easy to relocate. Also I agree that my-bus-extensions.txt is not a good but let's treat it as a temporary solution. I'll update it if there's a better way. However, even the resource files under META-INF/cxf are not shaded, the package works well for me. If you're encountering some issues please tell me. Btw there's one thing confused me, seems in google shadowJar it doesn't relocate any packages. Wondering why it can solve conflicts... |
Could you provide a shadowJar version of the Bing API SDK? The new version of the SDK depends on several JAR packages that conflict with other frameworks used in our project.
The Google Ads SDK provides a shadowJar version(https://mvnrepository.com/artifact/com.google.api-ads/google-ads-shadowjar), which has brought great convenience for our integration with the Google Ads API.
The text was updated successfully, but these errors were encountered: