Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons for buttons suggestions #162

Closed
glassbase opened this issue Apr 3, 2024 · 5 comments · Fixed by #163
Closed

Icons for buttons suggestions #162

glassbase opened this issue Apr 3, 2024 · 5 comments · Fixed by #163
Assignees
@BigThunderSR
Labels
enhancement New feature or request

Comments

@glassbase
Copy link

glassbase commented Apr 3, 2024 •
edited
Loading

Just some friendly suggestion to add icons for the new button commands :)

Here are a few recommendations:
start = mdi.engine
cancel start = mdi:engine-off
lock = mdi.car-door-lock
unlock = mdi.car-door-lock-open
location= mdi:map-marker-radius
diagnostics = mdi;car-cog --or-- mdi:car-info

Love the work you have been doing on this project.
@BigThunderSR BigThunderSR added the enhancement New feature or request label Apr 3, 2024
@BigThunderSR
Copy link
Owner

OK, let me see what I can do.

@BigThunderSR BigThunderSR linked a pull request Apr 4, 2024 that will close this issue
Add icons to buttons published via MQTT auto-discovery #163
Merged
@BigThunderSR
Copy link
Owner

@glassbase, request has been implemented in v1.18.0. Please test and confirm.

@BigThunderSR
Copy link
Owner

BigThunderSR commented Apr 6, 2024 •
edited
Loading

@glassbase, is everything working as expected now after #166 was fixed?

@BigThunderSR
Copy link
Owner

@glassbase, have you had a chance to test yet?

@BigThunderSR
Copy link
Owner

Closing due to no response. Please re-open if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BigThunderSR BigThunderSR

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add icons to buttons published via MQTT auto-discovery BigThunderSR/onstar2mqtt
2 participants
@BigThunderSR @glassbase