Fix missing arrival when sending lords & donkeys

[bob0005]

Summary by CodeRabbit

• New Features

  • Introduced a new resource tracking constant to enhance resource evaluation criteria.

• Bug Fixes

  • Updated logic to include additional resource types for determining special resources.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eternum	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Dec 24, 2024 1:04pm
eternum-docs	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Dec 24, 2024 1:04pm
eternum-landing	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Dec 24, 2024 1:04pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces a new constant LORDS_AND_DONKEY_RESOURCE_TRACKER in the use-resource-arrivals.tsx file. This constant is integrated into the createArrivalInfo function, expanding the conditions for identifying special resource types. The modification allows for an additional resource tracker type to be recognized alongside the existing LORDS_RESOURCE_TRACKER, potentially broadening the scope of resource handling logic in the application.

Changes

File	Change Summary
client/src/hooks/helpers/use-resource-arrivals.tsx	Added LORDS_AND_DONKEY_RESOURCE_TRACKER constant and updated resource type checking condition

Possibly related PRs

• weight fix #2355: Modifies use-resource-arrivals.tsx file with similar resource management logic
• remove lords filter #2588: Alters resource filtering to include "Lords" resources

Suggested reviewers

• edisontim

Poem

🐰 A rabbit's tale of resources rare,
Lords and donkeys, a tracker's flair!
New constant springs, with logic bright,
Expanding checks with all its might
Resource magic, coded with care! 🦊

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3b90c91 and ff911f0.

📒 Files selected for processing (1)

• client/src/hooks/helpers/use-resource-arrivals.tsx (2 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mentatbot]

The changes look good and appropriately fix the issue of missing arrivals when sending both Lords and Donkeys. The implementation is clean and follows existing patterns. The LORDS_AND_DONKEY_RESOURCE_TRACKER constant value is correctly calculated as the sum of the other two tracker values. The code changes maintain good readability while fixing the functionality.

Thanks for using MentatBot. Give comments a 👍 or 👎 to help me improve!

[mentatbot]

Consider adding documentation comments above these constants to explain what each resource tracker represents and how they're used. This would help future maintainers understand the significance of these magic numbers.

Suggested change

	const DONKEY_RESOURCE_TRACKER = 452312848583266388373324160190187140051835877600158453279131187530910662656n;
	const LORDS_RESOURCE_TRACKER = 7237005577332262213973186563042994240829374041602535252466099000494570602496n;
	/**
	* Represents a resource tracker for donkey-related resources.
	* Used to track entities that are specifically carrying donkey resources.
	*/
	const DONKEY_RESOURCE_TRACKER = 452312848583266388373324160190187140051835877600158453279131187530910662656n;
	/**
	* Represents a resource tracker for LORDS tokens.
	* Used to track entities that are carrying LORDS token resources.
	*/
	const LORDS_RESOURCE_TRACKER = 7237005577332262213973186563042994240829374041602535252466099000494570602496n;
	/**
	* Combined resource tracker for both LORDS tokens and donkey resources.
	* This tracker is the sum of DONKEY_RESOURCE_TRACKER and LORDS_RESOURCE_TRACKER,
	* used to track entities carrying both types of resources simultaneously.
	*/

[github-actions]

Failed to generate code suggestions for PR