Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean operators don't work deep inside a requirement #296

Closed
3 tasks done
dfremont opened this issue Aug 5, 2024 · 0 comments · Fixed by #299
Closed
3 tasks done

Boolean operators don't work deep inside a requirement #296

dfremont opened this issue Aug 5, 2024 · 0 comments · Fixed by #299
Assignees
Labels
status: valid Issue is valid and will be worked on type: bug Something isn't working

Comments

@dfremont
Copy link
Collaborator

dfremont commented Aug 5, 2024

System Details

  1. Python 3.11.1
  2. Scenic latest main branch (5f134ad)
  3. macOS Sonoma 14.5

Detailed Description

Issue #286 also occurs for the and and or operators inside an atomic proposition in a temporal requirement.

Thanks to Daniel Genin for the original report.

Steps To Reproduce

Code like the following is miscompiled into 3 AtomicProposition nodes instead of 1 (visible using --dump-python):

require eventually all(True and False for _ in range(2))

Issue Submission Checklist

  • I am reporting an issue, not asking a question
  • I checked the open and closed issues, forum, etc. and have not found any solution
  • I have provided all necessary code, etc. to reproduce the issue
@dfremont dfremont added type: bug Something isn't working status: valid Issue is valid and will be worked on labels Aug 5, 2024
@Eric-Vin Eric-Vin mentioned this issue Aug 6, 2024
4 tasks
@Eric-Vin Eric-Vin linked a pull request Aug 6, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: valid Issue is valid and will be worked on type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants