feat: include interaction diffs in verification response

cc: @TimothyJones
Benjaminpjacobs · Feb 25, 2021 · 6306693 · 6306693
1 parent c372104
commit 6306693
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/lib/pact/mock_service/interactions/verification.rb b/lib/pact/mock_service/interactions/verification.rb
@@ -38,6 +38,10 @@ def missing_interactions
           expected_interactions - actual_interactions.matched_interactions - @actual_interactions.interaction_mismatches.collect(&:candidate_interactions).flatten
         end
 
+        def interaction_mismatches
+          actual_interactions.interaction_mismatches
+        end
+
         private
 
         attr_reader :expected_interactions, :actual_interactions

diff --git a/lib/pact/mock_service/request_handlers/verification_get.rb b/lib/pact/mock_service/request_handlers/verification_get.rb
@@ -52,7 +52,7 @@ def initialize verification
           def to_s
             titles_and_summaries.collect do | title, summaries |
               "#{title}:\n\t#{summaries.join("\n\t")}\n\n" if summaries.any?
-            end.compact.join
+            end.compact.join + verification.interaction_mismatches.collect(&:to_s).join("\n\n") + "\n"
 
           end
 

diff --git a/spec/lib/pact/consumer/mock_service/verification_get_spec.rb b/spec/lib/pact/consumer/mock_service/verification_get_spec.rb
@@ -105,13 +105,15 @@ module RequestHandlers
         describe "FailureMessage" do
           let(:missing_interactions_summaries) { ["Blah", "Thing"]}
           let(:interaction_mismatches_summaries) { []}
+          let(:interaction_mismatches) { []}
           let(:unexpected_requests_summaries) { []}
           let(:verification) { instance_double("Pact::Consumer::Verification") }
           subject { VerificationGet::FailureMessage.new(verification).to_s }
 
           before do
             allow(verification).to receive(:missing_interactions_summaries).and_return(missing_interactions_summaries)
             allow(verification).to receive(:interaction_mismatches_summaries).and_return(interaction_mismatches_summaries)
+            allow(verification).to receive(:interaction_mismatches).and_return(interaction_mismatches)
             allow(verification).to receive(:unexpected_requests_summaries).and_return(unexpected_requests_summaries)
           end
 
@@ -122,6 +124,7 @@ module RequestHandlers
 \tBlah
 \tThing
 
+
 EOS
 }
             it "only includes missing interactions" do
@@ -132,6 +135,7 @@ module RequestHandlers
           context "with missing, mismatches and unexpected interactions" do
 
             let(:interaction_mismatches_summaries) { ["wiffle"]}
+            let(:interaction_mismatches) { ["diffs"]}
             let(:unexpected_requests_summaries) { ["moose"]}
 
             let(:expected_string) { <<-EOS
@@ -145,6 +149,7 @@ module RequestHandlers
 Unexpected requests:
 \tmoose
 
+diffs
 EOS
 }
             it "includes all the things" do