Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: replace Matrix{Bool} values with actual directed graphs from Graphs.jl. #77

Closed
iago-lito opened this issue Nov 22, 2022 · 3 comments

Comments

@iago-lito
Copy link
Collaborator

Suggested in reaction to #76 because directed graphs is what is actually represented by most matrices in the package. Not sure what the cons and pros are here, except that it's not something worth bothering with yet, at least not before the next release. I'm just dropping it here for the records ;)

@ismael-lajaaiti
Copy link
Collaborator

The big pro would be that we (developers) and the user could use directly algorithms from Graphs.jl, for instance to compute centrality metrics or search for communities.
I assume that the con is that we would be dependent of a structure that we didn't create, thus we don't have full control over it. But at this point, the trade-of seems very positive to me.

@iago-lito
Copy link
Collaborator Author

This change would be easier after #84 is addressed.

@iago-lito
Copy link
Collaborator Author

Closing in favour of #141.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants