Improve ReadMe #22
Improve ReadMe #22
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #22 +/- ##
==========================================
- Coverage 98.86% 97.41% -1.45%
==========================================
Files 2 2
Lines 88 116 +28
==========================================
+ Hits 87 113 +26
- Misses 1 3 +2
☔ View full report in Codecov by Sentry. |
|
I'm also asking myself why tests get always cancelled |
|
ok now this doesn't happen with the change on CI. Does the library need to test so many versions? Can we remove the 1.6? And is testing nightly a good thing? see https://discourse.julialang.org/t/why-do-packages-run-continuous-integration-tests-on-julia-nightly/101208/3 |
I do think it is good practice to test the lower and upper bound of your compat range. Nightly is not as important and shouldn't cause tests to get cancelled, which I fixed. But it is niceto get a heads up, if things break, ideally there would be a way to test on the latest release candidate, but I am not aware of that. |
|
Ok, perfect, then I think with your latest improvements this is also good to go. Can you release a new version after that? Since #23 is very good to have for the integration in Agents.jl |
BeastyBlacksmith
merged commit fd8b56a
into
BeastyBlacksmith:master
The Build Status wasn't working so I removed it. Unfortunately redef doesn't work on >1.8 so I don't know if mentioning it is a good thing (I spent sometime trying it and asking myself why it didn't work), the author said it's probably not fixable here: FedericoStra/RedefStructs.jl#4