Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basin UI - (1) QoL fixes & UI tweaks #687

Closed
wants to merge 28 commits into from
Closed

Basin UI - (1) QoL fixes & UI tweaks #687

wants to merge 28 commits into from

Conversation

Space-Bean
Copy link
Contributor

@Space-Bean Space-Bean commented Nov 12, 2023 •
edited
Loading

  1. Add commas to USD Values
  2. fix 'Add Tokens in Balanced proportion' in 'Add Liquidity'
  3. show USD Value of user's LP Positions + add breakdown tooltip
  4. Rename BEANWETHCP2w to BEANETH LP in the UI
  5. add Bean logo to footer
  6. fix button text 'Connect Wallet' when no wallet is connected
  7. fix 'insufficient balance' button text when swap tokens are equal
  8. Fix Liquidity page broken when no events

See Notion for ticket details
https://www.notion.so/beanstalk-farms/QoL-improvements-2de0e040f34f485383e752a3cda7e3f4?pvs=4

Responsive UI on medium viewports will be resolved in new ticket

Review this one before Basin UI - Design Tweaks PR: #692

@Space-Bean
[wip]: update formatting on dex-ui mobile Wells page + add formatNum fn
0ba7c77
@Space-Bean
fix token amounts when balanceMode is toggled
d6d0ed6
@Space-Bean
[wip]: LP token price hook + user positions in USD
b66d4fe
@Space-Bean
fix components for Liquidity Box
adba772
@Space-Bean
BEAN:ETH LP symbol display
dbd38d9
@Space-Bean
USD price in well table + modify useWellLPTokenPrice
e2beb48
@Space-Bean
update displayTokenSymbol fn + update in relevant places
126dce4
@Space-Bean
add Beanstalk Logo & Links to Footer & Frame
3501990
@Space-Bean
fix USD value
f1364a4
@Space-Bean
fix swap button label if tokens are same
e6a99d7
@Space-Bean
fix add liquidity no wallet button label
cbdc274
@Space-Bean
fix my lp positions table when no positions
9f8eb83
@Space-Bean
FIX: well page broken if brand new well
d039410
@Space-Bean
update useWellLPtokenPrice
d0ab578
@Space-Bean
implement lp USD price
5b1f423
@Space-Bean
add useTokenBalanceInternal & implement
3a1dd79
@Space-Bean
add tooltip for usd total breakdown
c193cba
@Space-Bean
remove logs + fix divide by 0
f130164
@netlify Netlify
Copy link

netlify bot commented Nov 12, 2023 •
edited
Loading

✅ Deploy Preview for basin canceled.

Name Link
🔨 Latest commit d9045ea
🔍 Latest deploy log https://app.netlify.com/sites/basin/deploys/65755640191979000839cab0

@netlify Netlify
Copy link

netlify bot commented Nov 12, 2023 •
edited
Loading

❌ Deploy Preview for beanstalk-ui failed.

Name Link
🔨 Latest commit d9045ea
🔍 Latest deploy log https://app.netlify.com/sites/beanstalk-ui/deploys/65755640589bf80008736f6d

@Space-Bean Space-Bean changed the title DEX UI QoL Fixes [WIP]: Basin UI QoL fixes & UI tweaks Nov 16, 2023
@Space-Bean Space-Bean changed the title [WIP]: Basin UI QoL fixes & UI tweaks Basin UI QoL fixes & UI tweaks Nov 21, 2023
@Space-Bean Space-Bean changed the title Basin UI QoL fixes & UI tweaks Basin UI -QoL fixes & UI tweaks Nov 21, 2023
@Space-Bean Space-Bean mentioned this pull request Nov 21, 2023
Closed
@hellofromguy hellofromguy changed the title Basin UI -QoL fixes & UI tweaks Basin UI - (1) QoL fixes & UI tweaks Nov 30, 2023
@Space-Bean Space-Bean mentioned this pull request Dec 10, 2023
Merged
@Space-Bean Space-Bean closed this Dec 10, 2023
@Space-Bean Space-Bean deleted the spacebean/dex-ui/qol-fixes branch August 13, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uncoolzero uncoolzero uncoolzero left review comments

@hellofromguy hellofromguy hellofromguy left review comments

@0xalecks 0xalecks Awaiting requested review from 0xalecks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Space-Bean @hellofromguy @uncoolzero