Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto len calculation buffer overflow #7

Open
AGraber opened this issue May 3, 2019 · 0 comments
Open

Auto len calculation buffer overflow #7

AGraber opened this issue May 3, 2019 · 0 comments

Comments

@AGraber
Copy link

AGraber commented May 3, 2019

Regarding e1a9824, this "auto len calculation" by doing strlen to the final format string buffer is very prone to cause buffer overflows. The amx_SetString function won't be able to notice the array's real size and will just write out of bounds. The reason why the format required the size is to protect against this, not to arbitrarily limit the string output.

Why was this done in the first place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant