Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX FACTS #1422

Open
2 tasks done
kodjima33 opened this issue Nov 27, 2024 · 14 comments
Open
2 tasks done

FIX FACTS #1422

kodjima33 opened this issue Nov 27, 2024 · 14 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@kodjima33
Copy link
Collaborator

kodjima33 commented Nov 27, 2024

  • - 1st issue: 2 weeks ago I had 100 facts. Today I still have 100 facts. (see pics as proofs)
  • - 2nd issue: facts should be not just about what I like

More context:
Current facts collected about the user are some AI-generated bullshit like "Nikita is interested" or "Nikita enjoys"

As a developer, when using facts, I'm not even able to extract useful information such as "city of living", "age", etc...

Describe the solution you'd like
I want facts to contain actually useful information such as
Age, city of living, marriage status, health, friends names, relationships, preferences, allergies. Imagine an FBI report on a person - that's exactly how it should be.

Pics
Clipboard 26 Nov 2024 at 22 36
IMG_3522

@kodjima33 kodjima33 added the bug Something isn't working label Nov 27, 2024
@kodjima33 kodjima33 moved this to To do in omi TODO Nov 27, 2024
@kodjima33 kodjima33 added the help wanted Extra attention is needed label Nov 27, 2024
@josancamon19 josancamon19 self-assigned this Nov 27, 2024
@josancamon19 josancamon19 moved this from To do to In progress in omi TODO Nov 27, 2024
@josancamon19
Copy link
Contributor

CleanShot 2024-11-27 at 13 43 11@2x

Doesn't seem to have stopped creating new facts, even Salman is getting new ones.
But it will not add new facts if feels like it's repeating itself with stuff already knows about you.

@josancamon19
Copy link
Contributor

For context:

Image

@josancamon19
Copy link
Contributor

I see you again have 100 facts, but they seem to be on different categories?

@josancamon19
Copy link
Contributor

In COMPLETELY different categories, wtf? why? how? was this after you changed the prompt? did you clean up your facts?

@josancamon19
Copy link
Contributor

I understand habits, lifestyle, hobbies are really few or none, but can you provide with a few conversations examples, and provide this one should include this facts.

Or how facts should be determined? for example, unless you have said that you live in San Francisco, it will prob not determine that you live there, as that'd be an inference based on your conversations, not a fact.

@kodjima33
Copy link
Collaborator Author

kodjima33 commented Nov 27, 2024

@josancamon19 no bro didn't delete but hahaha today I reopened the app, my facts got reshuffled into different categories again :D

I just opened again, I have still 100 but now it's
1 hobby
11 interests
71 work
5 other
1 skill
11 lifestyle

@josancamon19
Copy link
Contributor

I just pushed to prod test in 20 min, you should have like 2.5k facts, is bad for other reasons, but it should be better, lmk.

@josancamon19
Copy link
Contributor

Check 2) again if you have facts like those you put as example

@josancamon19 josancamon19 moved this from In progress to In review in omi TODO Nov 28, 2024
@josancamon19
Copy link
Contributor

@beastoin moved this to in-review, please check this file

Run it with your id, and check how the facts results improved compared to previous ones.

@josancamon19
Copy link
Contributor

I can confirm this part was executed:
Image

@josancamon19
Copy link
Contributor

Should we filter |||| As a developer, when using facts, I'm not even able to extract useful information such as "city of living", "age", etc... |||| only "core" facts into apps prompts?

@beastoin
Copy link
Collaborator

https://docs.google.com/spreadsheets/d/1DMc4GjJTc0JzkY6tWHC0PV-z9T2zzZXFyLppKN_gAAQ/edit?gid=1103725368#gid=1103725368 my facts

at core - 44/58 - 75% good.

they covered my living, age, marriage status, family, experiences, ...

@beastoin
Copy link
Collaborator

Screenshot 2024-11-30 at 18 38 51 there's some duplicated facts at core, e.g. ^

@beastoin
Copy link
Collaborator

Should we filter |||| As a developer, when using facts, I'm not even able to extract useful information such as "city of living", "age", etc... |||| only "core" facts into apps prompts?

should we pick 25 facts each category, or go with some ratio e.g. 50:20:10:10:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Status: In review
Development

No branches or pull requests

3 participants