Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and Enable Real-time Audio Bytes to Trigger Events #1395

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mdmohsin7
Copy link
Collaborator

@mdmohsin7 mdmohsin7 commented Nov 23, 2024

Closes #1336

Add the ability for apps to receive real-time audio bytes. This opens up the possibility of building a lot more applications utilising real-time audio.

The implementation is hardcoded to send audio bytes every 30 seconds. Should I allow the creators to define the duration @thinhx?

Tested locally and it works
Screenshot 2024-11-23 at 10 21 36 PM

@beastoin
Copy link
Collaborator

this is a cool feature!

btw bro, do you think ppl would like to allow their voice go through another app but not Omi ?

allow the creator define the duration?

yes, min 5s

@mdmohsin7
Copy link
Collaborator Author

mdmohsin7 commented Nov 26, 2024

I think there are use cases that omi does not cater to (for now). This would allow creators to create apps to store recordings in gdrive/icloud, sentiment analysis and other use cases which we aren't aware of maybe?

btw bro, do you think ppl would like to allow their voice go through another app but not Omi ?

I guess it will depend on the app, if they want to use it and it isn't privacy invasive, then they'll use it

@beastoin
Copy link
Collaborator

so, let's do a small survey(as a simple decision making framework), if we have 6 votes for this feature (in any platforms) then we go with it, is it okay?

about the implementation:
1/ you should check if the user installed at least 01 audio-byte triggered app or not, before setting up the pusher's audio consume
2/ at pusher, your implement is not support for the different thresholds yet e.g, users installed multiple audio-byte triggered app and they have different threshold to received audio bytes.

so so complicated, right ? so let finish the survey first :)

@mdmohsin7
Copy link
Collaborator Author

Yes I did not move forward with continuing the implementation because I too wasn't sure if we really should add this, hence 1/ and 2/ are not done. As you mentioned, let's go with a survey and then decide whether we should really add this or not

I've progressed a lot, now this stuff doesn't seem to be very complicated to me XD (thanks to you and Joan)

@beastoin beastoin marked this pull request as draft November 28, 2024 03:54
@mdmohsin7
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Real-Time Audio Bytes Trigger Event
2 participants