Possible to use variables? Where is the config stored?

[kenherring]

A few questions or suggestions for you. I'll probably add some more as I find them if it's OK with you @PauliusKu

BTW I finally got this sort of working with our DBs running in docker containers. Pretty neat stuff! Looking forward to seeing how this evolves.

Questions

1. When we run DBs in WSL it's often faster to connect via the WSL ip address rather than localhost. The problem with that is each of our engineers will have a different WSL ip address. Would it be possible to use a variable in the host name field?
2. Where are the connection settings stored? Is it possible to have the config in the repo so it can be shared amongst engineers?
3. Connections across the network are pretty slow. Does this extension happen to use any caching of the schema? If not we would find that incredibly useful.

Suggestions

• In the OpenEdge Explorer: Databases view:
  • The delete button should give a warning message before actually deleting. Something like "Delete connection ()?". It's too easy to hit this by accident.
  • It would be nice to have a refresh button for individual connections rather than all connections only.
• In the Tables view it would be nice to see the list of tables from all DBs rather than just the selected DB. It would make filtering much more useful when we don't know which DB has a given table. Something like <dbname>.<tablename> rather than just <tablename>.
• For the provided settings it seems they all start with ProBro and generally use camel case. From what I can see all the other settings we use for various built-ins and extensions use all lower case, at least for the leading portion. Might be a good idea to use probro or pro-bro for consistency.
• When creating multiple DBs in a group they sort by the order the DBs were added. Would be nice if this could be re-arranged.
• Similar to Enable possibility to disable openedge-project.json automatic import #393 it would be cool if we could disable connections somehow. Maybe right click in the **OpoenEdge Explorer: Databases" view.
• Viewing the Edit Connection screen for any of the connections imported from openedge-build.json shows a blank screen. A read-only screen showing the settings used would be cool.
  
  • Also, should this say openedge-project.json? I'm not actually sure what openedge-build.json is.
• When using windows and configuring "terminal.integrated.defaultProfile.windows": "Git Bash", we get all sorts of errors. This is where I was having a lot of trouble getting this working before. When using Git Bash I believe the extension is having a difficult time with the path separator because it uses / instead of \.
• This right-click menu looks weird. DataBases instead of Databases, and a few blank translations.
  

[PauliusKu]

Hi @kenherring, thanks for your effort.

Answering your questions:

1. I think it would be possible to implement this. The question is where to put these variables.
2. Connections are stored in default vscode storage. If you want to update connections often, you should use openedge-project.json for that.
3. We didn't have a look into it. We'll check what performance benefits it could provide.

Regarding your suggestions I created separate tickets:

1. Delete button warning - Delete button warning #398
2. Individual refresh button - Individual refresh button for connections #399
3. Full list of tables. I think we might try to implement that via multi db select where you could select multiple DBs and see combined list of tables - Connection multi select #400
4. Settings naming consistency - Fix Settings naming consistency #401
5. Connections rearrangement - Custom connections rearrangement #402
6. Disable connection button - Disable connection button #403
7. Read only screen for imported connections - Read only screen for imported connections #404
8. Fix description naming from openedge-build.json to openedge-project.json - Fix description naming from openedge-build.json to openedge-project.json #405
9. Git bash terminal issues - could you elaborate more on these problems you encountered?
10. Missing index and field view names in right click menu - Missing index and field view names in right click menu #406

Thanks again for your input 👍

[kenherring]

Thanks for the update @PauliusKu .

Connections are stored in default vscode storage. If you want to update connections often, you should use openedge-project.json for that.

Thanks. The use case I was thinking of is that all developers on a project are using the same config and don't want to use openedge-project.json for some reason. Using the vscode default storage doesn't allow for uploading the config as a file to the repo. Storing the config directly in the repo would be a worthwhile change to improve portability.

Thanks again! Looking forward to testing out future updates.

[PauliusKu]

@kenherring

Storing the config directly in the repo would be a worthwhile change to improve portability

what format do you have in mind here? Should it be config.df?