Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: turn report validations into real pr checks #1564

Open
gosuto-inzasheru opened this issue Dec 9, 2024 · 1 comment
Open

feat: turn report validations into real pr checks #1564

gosuto-inzasheru opened this issue Dec 9, 2024 · 1 comment

Comments

@gosuto-inzasheru
Copy link
Collaborator

we should enforce not being able to merge a pr if a validation doesnt come back positive. eg merging should be blocked if a bip payload is missing a bip# or if a gauge add is not preferential
@gosuto-inzasheru
Copy link
Collaborator Author

also consider not saving/pushing the report.txt to the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gosuto-inzasheru