Review and Deploy sdBAL vester

[Tritium-VLK]

https://github.com/stake-dao/sd-token-vestor/tree/main

[Tritium-VLK]

Note from Warren at sdbal:
Hey @tritium_vlk

We did a final review, made a couple changes to optimize the rewards flow better in case we makes some changes in our side in the reward distributions

https://github.com/stake-dao/sd-token-vestor/tree/main

Added a small part in the readme on how to claim voting rewards

He 2x confirmed they call this done/it will work. Have done a first pass reiview myself and everything looks fine. Will take another look later. @gosuto-inzasheru can you also have a look, and then IMO it's probs fine to deploy the factory/start using it. I can check with StakeDAO about who deploys the factory.

[gosuto-inzasheru]

stake-dao/sd-token-vestor#1

[Xeonus]

Verify that delegation assumed upon deposit or does it have to be done explicitly?

[gosuto-inzasheru]

delegation is done on construction:

/// @notice Contract initializer
/// @param _beneficiary Address of the beneficiary that will be able to claim tokens
function initialize(address _beneficiary) public initializer {
    /// Initialize factory address.
    FACTORY = msg.sender;

    /// Initialize beneficiary.
    beneficiary = _beneficiary;

    /// Delegate to Stake DAO delegation.
    IDelegate(DELEGATION_REGISTRY).setDelegate(DELEGATION_SPACE, DELEGATION);
}

however, it can be updated by the manager if necessary:

/// @notice Update delegation to Stake DAO delegation
/// @param _delegate Address of the delegate
function updateDelegation(address _delegate) external onlyRole(MANAGER_ROLE) {
    IDelegate(DELEGATION_REGISTRY).setDelegate(DELEGATION_SPACE, _delegate);
}

[gosuto-inzasheru]

vests 1735417835; 2024-12-28T21:30:35 CET