Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zkEVM OZ Injector Poker upon activation of new Poker #18

Closed
Xeonus opened this issue Nov 22, 2024 · 4 comments · Fixed by #20
Closed

Remove zkEVM OZ Injector Poker upon activation of new Poker #18

Xeonus opened this issue Nov 22, 2024 · 4 comments · Fixed by #20
Assignees

Comments

@Xeonus
Copy link
Contributor

Xeonus commented Nov 22, 2024

Once BalancerMaxis/multisig-ops#1507 is executed make sure to

DisableOZ defender job
by setting the disable flag on OZ Defender dependencies in the deployment repository

so that for any future deployments it stays disabled. We should not delete the code for now.

@Xeonus Xeonus self-assigned this Nov 22, 2024
@gosuto-inzasheru gosuto-inzasheru transferred this issue from BalancerMaxis/multisig-ops Nov 24, 2024
@gosuto-inzasheru
Copy link

  1. i moved the ticket from msig ops to this repo
  2. pr#1507 is execd

@gosuto-inzasheru
Copy link

@Xeonus i paused it through the oz ui, is that enough or not?

@Xeonus
Copy link
Contributor Author

Xeonus commented Nov 24, 2024

@gosuto-inzasheru we need to modify the js file to disable the job, so if we do another deployment with additional changes, it will not be overwritten and enabled again. Adjusted specs to make that clear

@Xeonus
Copy link
Contributor Author

Xeonus commented Nov 25, 2024

Resolved with #20

@gosuto-inzasheru gosuto-inzasheru linked a pull request Nov 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants