-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync incomplete #600
Comments
Sync is reattempting it, but after 4 or 5 failed attempts it gives up. The cloud service must have been down for a while, I guess. I think we should change the retry mechanism to try for a longer period of time (minutes) instead of giving up after a certain number of attempts... |
Yeah, in my use case I would prefer for it to keep trying to sync the files for as long as it takes. Maybe a way to make it wait and reattempt every x amount of time until it completes a successful upload and continues on. |
any updates on this? I'm getting |
The number of retries has been increased a few versions ago, perhaps if you update to the latest version the problem will go away? As for reworking the retry mechanism, it's important to understand what the expectation of the user is before I can do any changes in the code. Adding an Would something like |
I think implementing an exponential backoff (no point spamming all the time if it's not gonna work anyway) and a retry limit would be a good solution.
It's not really infinite it has a timeout is it, so maybe just Edit: Another thing to consider is whether the retry limit should apply to a single failure or the entire process. One way to do this would be to terminate the process if the time since the start is greater than the limit and a failure occurred. But the problem with this approach is that it has the potential to break huge one-off transfers. Maybe we could use a combination of the two approaches? Something like:
Or am I just overcomplicating things? |
Rerunning the sync command worked for me, it found the missing files and uploaded those. You can consider adding a help message after |
P.S. Before implementing a retry flag please consider whether poor network is the only reason sync fails. For me all the failures were due to this error:
Until you've enumerated all the possible errors I'm not sure how to identify which ones should be handled by the cli tool and which ones should be left to the user to debug. |
I'm using the command line to sync a lot of small files to B2. A typical sync is 600,000 files and a couple hundred Gb in size. When performing syncs occasionally they will go through without an issue but most of the time I will see 503 errors. I know how B2 works so this is usually not concerning but on a large sync with 10-15 threads running sometimes I will see this for a couple minutes straight with no successful uploads. At the same time I see the "updated files" count increasing and when the sync does finish I receive a "ERROR: sync is incomplete". If they are 503 errors shouldn't the sync be reattempting the connection?
The text was updated successfully, but these errors were encountered: