Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static logos in this repository #13

Open
giovannipizzi opened this issue Mar 15, 2021 · 1 comment
Open

Use static logos in this repository #13

giovannipizzi opened this issue Mar 15, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@giovannipizzi
Copy link
Collaborator

As shown e.g. by #11, having only links to external logos is very fragile (people moving the logos in their repo, changing URL, ...) - they won't remember that it's referenced in the registry, and with the final effect of making the registry look like it's broken.

I suggest instead to have a 'static' folder in this repo, and ask people to put the file in there and point with a relative path to files in that folder (file existence can also be checked during the testing phase).

@csadorf
Copy link
Collaborator

csadorf commented Mar 15, 2021

I think that is a good suggestion and also something that can be easily checked as part of the automated tests.

@csadorf csadorf added the enhancement New feature or request label Mar 15, 2021
SimonStier added a commit to SimonStier/big-map-registry that referenced this issue Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants