You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
it looks like BoundsOfTransformed contains a bug, these lines should already operate on 8 points instead of 2 (transforming min/max will yield a wrong bounding box, we need to transform all 8 corners) - Query.CornerPoints can be helpful
also the method can be simplified: take all 8 corners, then transform by local transform of bbox, then by the extra transform param, finally get bounds of transformed points
transform input could be made optional and method renamed to simply Bounds to align with existing methods
let's make sure we have tests for it 😉
The text was updated successfully, but these errors were encountered:
Description:
From the conversation with @michal-pekacki:
BoundsOfTransformed
contains a bug, these lines should already operate on 8 points instead of 2 (transforming min/max will yield a wrong bounding box, we need to transform all 8 corners) -Query.CornerPoints
can be helpfultransform
input could be made optional and method renamed to simplyBounds
to align with existing methodsThe text was updated successfully, but these errors were encountered: