Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

clean_up() method breaks on SOURCES table #23

Open
hover2pi opened this issue Mar 14, 2016 · 2 comments
Open

clean_up() method breaks on SOURCES table #23

hover2pi opened this issue Mar 14, 2016 · 2 comments
Assignees
Labels

Comments

@hover2pi
Copy link
Member

Figure out how to run clean_up() on the SOURCES table. The only required column is id, which inherently won't be identical so what are we looking for in conflicted records?

The choices I see are:

  1. Don't run clean_up() on such tables, or
  2. Require at least one column other than id to be NOT NULL
@hover2pi hover2pi self-assigned this Mar 15, 2016
@dr-rodriguez
Copy link
Member

I would argue that at least the designation or shortname column should not be null.
We may also consider identifying duplicates by matching by RA/Dec within some radius.

@hover2pi
Copy link
Member Author

hover2pi commented Jun 3, 2016

Ok, we can do that. So in general we'll just make sure every table has a NOT NULL id column and one other.

Make sure NOT to just check the NOT NULL box in the SQLite Browser because db.clean_up() will then kick out all the records that fail this constraint. We have to first go in and make sure all records have something in that column.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants