feat : 생협 운영시간 이름으로 조회하기 추가 #1164
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choon0414
requested review from
songsunkook,
ImTotem,
DHkimgit,
dradnats1012 and
kih1015
kih1015
approved these changes
Jan 9, 2025
Comment on lines
+36
to
+42
| @GetMapping("/type/{coopShopType}") | ||
| public ResponseEntity<CoopShopResponse> getCoopShopByType( | ||
| @PathVariable CoopShopType coopShopType | ||
| ) { | ||
| CoopShopResponse coopShop = coopShopService.getCoopShopByType(coopShopType); | ||
| return ResponseEntity.ok(coopShop); | ||
| } |
There was a problem hiding this comment.
A
전체 생협매장에서 타입을 기준으로 조회하는 기능으로 보입니다.
새로 api를 추가하는 방식도 좋지만
아래와 같이 기존의 get /coopshop에서 required = false로 쿼리 스트링을 추가하는 것은 어떻게 생각하시나요?
get /coopshop?coopShopType=CAFTERIA
추가) 그런데 이렇게 하면 response 형식이 달라지긴 하네요 ㅠ
dradnats1012
approved these changes
Jan 9, 2025
| CAMPUS2("2캠퍼스"), | ||
| WELFARE_CVS("복지관 편의점"), | ||
| CHAMBIT_CVS("참빛관 편의점"), | ||
| CVS("복지관 참빛관 편의점"), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 연관 이슈
🚀 작업 내용
/coopshop/type/{coopShopType}/coopshop/{coopShopId})는 학기가 바뀔 때마다 Id를 수정해야 하는 문제가 생겨 추가하였습니다.💬 리뷰 중점사항