Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coverage plot #27

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Add coverage plot #27

merged 3 commits into from
Jul 5, 2024

Conversation

dfornika
Copy link
Member

Fixes #26

@dfornika dfornika requested a review from JamesZlosnik June 19, 2024 21:39
JamesZlosnik
JamesZlosnik approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@JamesZlosnik JamesZlosnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried on a GAS sample in both this pipeline running independently and as part of an autoanalysis. Seems to work well.

@JamesZlosnik
Copy link
Member

I've approved this, but now I am wondering if it might make sense to improve the resolution of the outputted plot, perhaps dpi = 300 ?

@dfornika dfornika merged commit ec4f531 into main Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesZlosnik JamesZlosnik JamesZlosnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add depth-of-coverage plotting
2 participants
@dfornika @JamesZlosnik