Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix Date-Time Parsing in Token Expiration Calculation for Multiple Formats #7393

Open
2 tasks
gladjohn opened this issue Oct 22, 2024 · 2 comments · May be fixed by #7529
Open
2 tasks

[Bug] Fix Date-Time Parsing in Token Expiration Calculation for Multiple Formats #7393

gladjohn opened this issue Oct 22, 2024 · 2 comments · May be fixed by #7529
Assignees
@Robbie-Microsoft
Labels
bug A problem that needs to be fixed for the feature to function as intended. confidential-client Issues regarding ConfidentialClientApplications msal-node Related to msal-node package p2 P1 and P2 are priorities of the bug. P2 bugs should get fixed/closed within 3 months.

Comments

@gladjohn
Copy link

gladjohn commented Oct 22, 2024 •
edited by Robbie-Microsoft
Loading

Core Library

MSAL.js (@azure/msal-node)

Core Library Version

latest

Public or Confidential Client?

Confidential

Description

The method responsible for calculating token expiration (expires_on) in MSAL (Managed Identity) is not handling various date-time formats correctly. This leads to errors or incorrect results when processing expiration times in different formats provided by the Managed Identity service.

more info : AzureAD/microsoft-authentication-library-for-dotnet#4963

Error Message

No response

MSAL Logs

No response

Network Trace (Preferrably Fiddler)

  • Sent
  • Pending

MSAL Configuration

Added parsing logic for Unix timestamps, ISO 8601

Relevant Code Snippets

Added parsing logic for Unix timestamps, ISO 8601

Reproduction Steps

Added parsing logic for Unix timestamps, ISO 8601

Expected Behavior

Added parsing logic for Unix timestamps, ISO 8601

Identity Provider

Entra ID (formerly Azure AD) / MSA

Browsers Affected (Select all that apply)

None (Server)

Regression

No response
@gladjohn gladjohn added question Customer is asking for a clarification, use case or information. bug-unconfirmed A reported bug that needs to be investigated and confirmed labels Oct 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Oct 22, 2024
@github-actions github-actions bot added confidential-client Issues regarding ConfidentialClientApplications msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package labels Oct 22, 2024
@gladjohn gladjohn removed msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package Needs: Attention 👋 Awaiting response from the MSAL.js team labels Oct 22, 2024
@Robbie-Microsoft Robbie-Microsoft added the msal-node Related to msal-node package label Oct 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Invalid Issue Template:
Please update the original issue and make sure to fill out the entire issue template so we can better assist you.

@github-actions github-actions bot added the more-information-needed Use this label when you are waiting on information from the issue creator label Oct 24, 2024
@gladjohn gladjohn mentioned this issue Jan 2, 2025
Merged
1 task
@bgavrilMS bgavrilMS added bug A problem that needs to be fixed for the feature to function as intended. p2 P1 and P2 are priorities of the bug. P2 bugs should get fixed/closed within 3 months. and removed question Customer is asking for a clarification, use case or information. more-information-needed Use this label when you are waiting on information from the issue creator bug-unconfirmed A reported bug that needs to be investigated and confirmed labels Jan 2, 2025
@AzureAD AzureAD deleted a comment from gladjohn Jan 22, 2025
@Robbie-Microsoft
Copy link
Collaborator

@bgavrilMS, @gladjohn In addition to expires_in, what about ext_expires_in, refresh_in, and refresh_token_expires_in? Should I make this change for these values as well? That way, I can future-proof the entire ServerAuthorizationTokenResponse.

@Robbie-Microsoft Robbie-Microsoft linked a pull request Jan 24, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Robbie-Microsoft Robbie-Microsoft

Labels
bug A problem that needs to be fixed for the feature to function as intended. confidential-client Issues regarding ConfidentialClientApplications msal-node Related to msal-node package p2 P1 and P2 are priorities of the bug. P2 bugs should get fixed/closed within 3 months.
Projects
None yet
Milestone
No milestone
3 participants
@bgavrilMS @Robbie-Microsoft @gladjohn