Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Scratch Buffer Index on MSCCL++ #29

Merged
merged 1 commit into from
Dec 3, 2024
+1 −5
Merged

Fixing Scratch Buffer Index on MSCCL++ #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions msccl/language/mscclpp/instruction_dag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,11 +487,7 @@ def is_scratch(buffer):
return buffer != Buffer.input and buffer != Buffer.output

def get_new_index(rank, buffer, index, size, i):
# Scratch buffers always use batched
if is_scratch(buffer):
buf_instance_len = self.buffers[rank][buffer].instance_size()
return buf_instance_len * i + index
elif replication_policy == ReplicationPolicy.interleaved:
if replication_policy == ReplicationPolicy.interleaved:
return index * instances + i * size
return len(self.buffers[rank][buffer]) * i + index

Expand Down
Loading