Skip to content

Commit

Permalink
WIP
Browse files Browse the repository at this point in the history
  • Loading branch information
Binyang2014 committed Dec 2, 2024
1 parent b1c625f commit 2d57ade
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions msccl/language/mscclpp/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ def _curr():
# If one sender what to send data to peer want to use different tb in receiver side. We need to send to same tb in receiver side first,
# then performance a across tb sync. This is a limitation of current implementation.
class MSCCLPPProgram:

def __init__(
self,
name: str,
Expand Down Expand Up @@ -339,7 +338,9 @@ def _reduce(self, other_chunkref, recvtb=-1, channel_type=ChannelType.sm, use_pa
dst = self.rank
src = other_chunkref.rank
assert self.prog.topo.link(src, dst) or src == dst, f"No link from {src} to {dst}"
self.prog.apply_reduce(src, other_chunkref.buffer, other_chunkref.index, dst, self.buffer, self.index, self.size)
self.prog.apply_reduce(
src, other_chunkref.buffer, other_chunkref.index, dst, self.buffer, self.index, self.size
)
if use_packet:
assert src == dst, "Packet reduce only supports intra-rank communication"

Expand Down

0 comments on commit 2d57ade

Please sign in to comment.