Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: s/syncOverwriteResaonNewerLMT/syncOverwriteReasonNewerLMT/g #2393

Closed
wants to merge 1 commit into from
Closed

fix: s/syncOverwriteResaonNewerLMT/syncOverwriteReasonNewerLMT/g #2393

wants to merge 1 commit into from

Conversation

chenrui333
Copy link

@gapra-msft
Copy link
Member

@chenrui333 Could you please change the base branch to dev. We generally merge into the dev branch for new changes.

@chenrui333
Copy link
Author

@chenrui333 Could you please change the base branch to dev. We generally merge into the dev branch for new changes.

yeah, totally.

@chenrui333
Copy link
Author

(sounds like you folks should update the repo's default branch to dev as well?)

@chenrui333 chenrui333 changed the base branch from main to dev September 29, 2023 21:59
@chenrui333
Copy link
Author

done!

@vivshin-genesys
Copy link

vivshin-genesys commented Oct 11, 2023

Any movements with this?

There is an obvious typo in
[cmd/syncComparator.go](https://github.com/Azure/azure-storage-azcopy/blob/main/cmd/syncComparator.go)

I also can see that there were some check failures for the latest commit regarding "syncComparator.go":

a756368

Check failure on line 117 in cmd/syncComparator.go
GitHub Actions / lint (1.18, ubuntu-latest)
undefined: syncOverwriteResaonNewerLMT (typecheck)

@gapra-msft
Copy link
Member

Hi @chenrui333, it looks like this is already resolved in the dev branch. This will be released as part of our next release cycle. Thanks! Feel free to close this PR after confirming the same.

syncComparatorLog(sourceObject.relativePath, syncStatusOverwritten, syncOverwriteReasonNewerLMT, false)

@gapra-msft
Copy link
Member

This is now fixed in main. Closing this PR as a result.

@gapra-msft gapra-msft closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants